GNOME Bugzilla – Bug 358313
Song Lyrics plugin sometimes fetches wrong lyrics.
Last modified: 2009-06-27 10:50:05 UTC
Please describe the problem: Song Lyrics plugin sometimes fetches wrong lyrics. Eg. for „Drudkh - Eternal Turn of the Wheel“ I get lyrics of „Wheel Of Fortune - Ace Of Base“, for „Druth - Smell of Rain“ I get „Hatful Of Rain - Del Amitri“, etc. It's the same for all songs in the album. It seems like it just takes a part of title and searches for that, without comparing it to the original title. It's a black metal band, so lyrics might not exist on that lyrics server. But it should show that it was not found instead of fetching whatever lyrics. Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
I can confirm this. I would assume it uses some relaxed matching rules in case the Amazon title database is slightly different than the lyrics database, however, it will take the closest match, even if its not close at all.
*** Bug 409669 has been marked as a duplicate of this bug. ***
Yes, you're right! I can't understand why it does not check the title... this also happens with the cover art plugin...
As i wrote in the bugtracker on launchpad: "It is often not a problem with a lack of lyrics, often it's a problem with the plugin simply fetching the wrong lyrics. This mainly happens when there are "weird characters" in the title or artistname, f.ex. when i try to download lyrics from "Mevãdio - Walk with me"(which i know exists on leoslyrics, which rythmbox utilizes quite often, because i've added them myself a long time ago), it gives me "Dio - Walk On Water". This could be avoided by giving the user the opportunity to chose, which of the search results to use as lyrics, like in the original leos lyrics plugin for winamp. /eZtaR"
I can confirm this problem too.
I've added some fuzzy string matching to the lyrics plugin so it will only show results where the title and artist look somewhat like the strings we searched for. I haven't tested it extensively, but it filters out cases where the site has no lyrics for the requested song at all, and it matches well in cases of slight punctuation or spelling differences. commit 41dd5fadde967ac65e3a8e59b762cac1c3e92ac7 Author: Jonathan Matthew <jonathan@d14n.org> Date: Sun Jun 14 17:34:56 2009 +1000 lyrics: use fuzzy matches to check lyrics search results (bug #358313) This only applies to the leoslyrics.com and astraweb.com lyrics searches, as the others don't seem to return partial match results, or are too weird for me to figure out how to add this.