After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 357330 - [subparse] some sami parser minor but enhanced patch
[subparse] some sami parser minor but enhanced patch
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.10
Other Linux
: Normal enhancement
: 0.10.11
Assigned To: Tim-Philipp Müller
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-09-23 13:58 UTC by Young-Ho Cha
Modified: 2006-09-23 14:31 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16

Attachments
sami parser enhanced patch (1.42 KB, patch)
2006-09-23 14:00 UTC, Young-Ho Cha 		committed Details | Review

Description Young-Ho Cha 2006-09-23 13:58:18 UTC 
I'll submit some minor, but enhanced patch for sami parser.

It contains 3 minor bug fix.

1. At http://bugzilla.gnome.org/show_bug.cgi?id=169936#c28 , there is an workaround for converting "silver" value. But "silver" string is not case-sensitive. So it need to replace "xmlStrncmp" to "xmlStrncasecmp".

2. At Bug 344503, as well as No.1, face property is not case-sensitive, either.

3. At Bug 343303, there is an workaround for bad entities. but I missed to handle decimal entities (ex: &#xxxxx; ).

Would someone commit it please?

Thanks.
Comment 1 Young-Ho Cha 2006-09-23 14:00:48 UTC 
Created attachment 73276 [details] [review]
sami parser enhanced patch
Comment 2 Tim-Philipp Müller 2006-09-23 14:31:20 UTC 
Thanks, committed:

  2006-09-23  Tim-Philipp Müller  <tim at centricular dot net>

       Patch by: Young-Ho Cha <ganadist at chollian dot net>

       * gst/subparse/samiparse.c: (handle_start_font),
       (fix_invalid_entities):
         More case-insensitivity for certain tags; recognise entities with
         decimal codes as special entities as well (#357330).

(no need to use g_ascii_strncasecmp for the '#' character though).