After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 356970 - Repeated Character Count feature fails when reading messages in Evolution
Repeated Character Count feature fails when reading messages in Evolution
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: speech
1.0.x
Other All
: Normal minor
: ---
Assigned To: Rich Burridge
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-09-20 21:39 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2006-09-21 14:59 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
Patch to fix the problem. (698 bytes, patch)
2006-09-21 14:56 UTC, Rich Burridge
none Details | Review

Description Joanmarie Diggs (IRC: joanie) 2006-09-20 21:39:32 UTC
Please describe the problem:
The new Repeated Character Count feature (see: http://bugzilla.gnome.org/show_bug.cgi?id=354469) does not seem to work when reading messages in Evolution.

Steps to reproduce:
1. Open a message in Evolution that has repeated characters (see sample text below)
2. Arrow to the line with the repeated characters



Actual results:
Orca reads the individual characters (e.g. dash dash dash dash dash dash dash)

Expected results:
Orca would say "X such-and-such characters" (e.g. 7 dash characters)

Does this happen every time?
So far.... ;-)

Other information:
I ironically found by this reading the following text in Evolution:

------- Comment #22 from Rich Burridge  2006-09-20 21:23 UTC -------
The other thing I should mention is I've only been testing this
against gedit. If you try it with Evolution or StarOffice or
OpenOffice and you find problems that aren't present with gedit, 
please file separate bugs. I don't want this to be a catchall 
for all repeated character count problems. I'll never get to 
close it. ;-)
Comment 1 Rich Burridge 2006-09-20 23:21:00 UTC
Yup, this is as expected. There will need to be code added to
the Evolution.py script to handle this. It's going to be in clause
1) in the locusOfFocusChanged() method in Evolution.py. Something like
replacing:

  speech.speak(result[0])

with:

  line = self.adjustForRepeats(result[0])
  speech.speak(line)

I'll take a look at it tomorrow.

Comment 2 Rich Burridge 2006-09-21 14:56:23 UTC
Created attachment 73145 [details] [review]
Patch to fix the problem.
Comment 3 Rich Burridge 2006-09-21 14:59:58 UTC
Change checked into CVS HEAD. Closing as FIXED. Thanks for the bug report.