After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 355805 - add "mark group read before xover" to prefs dialog
add "mark group read before xover" to prefs dialog
Status: RESOLVED FIXED
Product: Pan
Classification: Other
Component: general
pre-1.0 betas
Other Linux
: Normal enhancement
: 1.0
Assigned To: Charles Kerr
Pan QA Team
Depends on:
Blocks:
 
 
Reported: 2006-09-13 15:48 UTC by Brad Hudson
Modified: 2007-01-22 15:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0.118 patch (1.38 KB, patch)
2006-11-09 16:35 UTC, Charles Kerr
none Details | Review
tweak previous patch (1.22 KB, patch)
2006-11-09 16:39 UTC, Charles Kerr
none Details | Review
better still (2.71 KB, patch)
2006-11-09 16:47 UTC, Charles Kerr
committed Details | Review
the string freeze is kind of slushy, so maybe this should be promoted to 1.0. (1.37 KB, patch)
2007-01-16 16:58 UTC, Charles Kerr
committed Details | Review

Description Brad Hudson 2006-09-13 15:48:01 UTC
The old version of Pan would mark all of a groups articles as read when you downloaded new headers.  This would make the "View only unread" filter show just the new articles.  I would like to see either a) The ability to show just the new articles or b) a preference item to allow you to mark all articles read when downloading new headers, as with the previous pan.

I see there is an option to mark articles read when you leave the group.  This would be similar.
Comment 1 Charles Kerr 2006-09-13 16:05:00 UTC
The distinction between new and unread is not going to come back
in the rewrite.  It's not a distinction that many (or any?)
other MUAs and newsreaders make, and confused a lot of users.

(b) is an option, though.
Comment 2 will 2006-10-06 12:53:08 UTC
sorry for my duplicate.  bug 359884.  i need to figure out a better way to express what i meant though. 
i don't miss the "only show new articles"- and new meaning the most recently downloaded articles(headers), as much as i miss having a seperate distinction between previously downloaded ( or read ), and not being part of the most recently downloaded batch of article headers.
I can "select all", then mark read, and then download new headers, which is what i'm doing now, or i can sort them all by date, and guess when i last downloaded headers, select those, and mark them read, if i forget to do so first.
Comment 3 will 2006-10-30 09:33:40 UTC
please, please.  the new pan is mentally exhausting to me when going back to get
files that were incomplete when most of the group were downloaded.  since i am now having to mark the headers as read before getting new headers, i do not have a way to see between actually downloaded, and just marked downloaded like the old pan could do with the new and old designation.
perhaps something like the flag being green when new or just downloaded headers,
yellow when part of the previous header download red when (read) or downloaded, or leaving it grey.
and having a way to show the specific colors of flags.  anything to end this ceaseless searching in large groups for missed parts.  I"m very worn out and frustrated.
I need to be able to search for a set of files containing a phrase, and tell at a glance which ones i've downloaded and which ones i've not.
i also have to be able to know which headers are new so i don't have to look through the same several thousand again.
Comment 4 djh 2006-11-09 06:07:19 UTC
> The distinction between new and unread is not going to come back in the rewrite.

How about if the 'show new articles' button is only displayed if enabled via a hidden option in preferences.xml?  Those of us that miss the feature (all 2 of us ;-)) could use it, and those who would be confused by it will never see it.
Comment 5 will 2006-11-09 15:37:51 UTC
i think we're on our own here. I often make little bitty changes to source code to get a program to do what i want, but i doubt i could do something that big.
Perhaps we find where in the code that headers are marked as read, figure out how that works, and think of it as old and new instead.  Call that function the few  times we want instead.
i'm getting used to the way it is though. we are perfectly free to use the old version too.
the only 2 things i've changed already are making the download list backup every 2 minutes instead of 10, and i've tried to change the length of the month, to make it dump headers 25 days old instead of 31.
Comment 6 Charles Kerr 2006-11-09 16:35:58 UTC
Created attachment 76281 [details] [review]
0.118 patch

Adds a preferences option to mark a group as read before fetching new headers.
Please test it out and see how it works.

There's not a preferences dialog option for this yet, since that would break
the version 1.0 translation string freeze, but you can enable it by editing
~/.pan2/preferences.xml by hand.
Comment 7 Charles Kerr 2006-11-09 16:39:42 UTC
Created attachment 76282 [details] [review]
tweak previous patch
Comment 8 Charles Kerr 2006-11-09 16:47:38 UTC
Created attachment 76284 [details] [review]
better still
Comment 9 will 2006-11-09 17:47:46 UTC
yeah, the second one wasn't working for me.
<flag name='mark-group-read-before-xover' value='true'/>

is what i'm adding to my prefs.  i just noticed from the code that it looks like xover tasks are supposed to be added to the top of the task list?  Mine always puts it on the bottom, and i have to move it to the top.  i thought i was supposed to have to do that.
Comment 10 will 2006-11-09 17:55:42 UTC
the third patch is working for me.  Thanks code animal.
Comment 11 will 2006-11-09 18:17:57 UTC
sorry to put this other crap here, but i wanted to put it quick.
selecting get new headers in selected group adds the task to the top.
selecting get headers . . ., bringing up that menu and picking "get new headers" from that sub menu puts the task at the bottom.
i think i'm too tired to file a bug report correctly.  i'll try tomorrow.
Comment 12 Charles Kerr 2006-11-09 23:38:46 UTC
Comment #11 is unrelated to this ticket and needs its own bug report.
Comment 13 Charles Kerr 2006-11-10 15:35:11 UTC
Comment #11 now has its own ticket in Bug 373193
Comment 14 Charles Kerr 2006-11-10 16:33:36 UTC
The attachment in comment #8 is now checked in for 0.119.

Leaving this ticket open so that a preferences dialog option
can be added for this after the 1.0 string freeze is lifted.
Comment 15 Charles Kerr 2007-01-16 16:58:15 UTC
Created attachment 80412 [details] [review]
the string freeze is kind of slushy, so maybe this should be promoted to 1.0.

I'd appreciate it if someone would test this patch out.
Comment 16 will 2007-01-18 14:20:39 UTC
the patch works for me at least as far as the "mark entire group read before getting new headers" box.