After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 354923 - Evolution does not store protocol in keyring entries
Evolution does not store protocol in keyring entries
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Mailer
2.24.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
evolution[passwords]
: 513667 521611 523522 532643 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-09-08 08:17 UTC by Dominik Schnitzer
Modified: 2013-09-14 16:52 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
Screenshot: smtp-auth entry in gnome-keyring-manager. Port 8025 is visible, but not in the Advanced-Options view (47.16 KB, image/jpeg)
2006-09-08 08:19 UTC, Dominik Schnitzer
  Details
Proposed patch (11.60 KB, patch)
2008-05-10 11:49 UTC, Matthew Barnes
committed Details | Review

Description Dominik Schnitzer 2006-09-08 08:17:58 UTC
Please describe the problem:
I have one account which uses SMTP AUTH for sending mail. Everytime I send mail, the Authentication Dialog pops up and asks for the SMTP AUTH Password, after entering the correct password everything works fine.

This could be happening because the SMTP Server runs on a different port: 8025

So my SMTP Server is configured as:
mail.server.com:8025

I'll attach a screenshot of the keyring.



Steps to reproduce:
1. Configure a SMTP Server using SMTP Auth
2. Send a mail
3. Authentication dialog pops up, you can save the password but it's not remembered for the next session


Actual results:
Authentication dialog pops up every evolution session

Expected results:
The mail should be sent right away using the credentials stored in gnome-keyring-manager

Does this happen every time?
yes, ervery new evo session

Other information:
Comment 1 Dominik Schnitzer 2006-09-08 08:19:44 UTC
Created attachment 72403 [details]
Screenshot: smtp-auth entry in gnome-keyring-manager. Port 8025 is visible, but not in the Advanced-Options view
Comment 2 André Klapper 2006-09-11 12:43:48 UTC
srini, can you please take a look at this?
Comment 3 Srinivasa Ragavan 2006-09-12 06:03:39 UTC
Dominik, I see that it is stored. I use the same option and it works for me. Are you sure, that password is right? It may popup again if it is wrong.
Comment 4 Dominik Schnitzer 2006-09-12 08:04:32 UTC
yes I'm sure. I've just had a closer look at this problem, and discovered the following:

1) I check my IMAP mail account. OK. (IMAP AUTH is in G-Keyring-Manager, 4th entry)

2) I send a mail with this account: SMTP AUTH Dialog pops up.

3) I enter the SMTP AUTH Password: now the 4th entry in Gnome-Keyring-Manager is OVERWRITTEN with the SMTP AUTH entry (from the screenshot)

4) I close everything & restart evo, now the IMAP AUTH Dialog pops up and asks me for a password and overwrites the SMTP AUTH entry....


I hope this helps :)
Comment 5 Xabier Rodríguez Calvar 2008-05-09 17:22:39 UTC
(In reply to comment #4)
> yes I'm sure. I've just had a closer look at this problem, and discovered the
> following:
> 
> 1) I check my IMAP mail account. OK. (IMAP AUTH is in G-Keyring-Manager, 4th
> entry)
> 
> 2) I send a mail with this account: SMTP AUTH Dialog pops up.
> 
> 3) I enter the SMTP AUTH Password: now the 4th entry in Gnome-Keyring-Manager
> is OVERWRITTEN with the SMTP AUTH entry (from the screenshot)
> 
> 4) I close everything & restart evo, now the IMAP AUTH Dialog pops up and asks
> me for a password and overwrites the SMTP AUTH entry....
> 
> 
> I hope this helps :)
> 

The same is happening to me with version 2.22. When dialog for incoming mail (POP3) pops up, I enter the password and it overwrites the password for outgoing mail that it is different and then the outgoing server answers with the error when trying to send mail. Password dialog shows a password with the same amount of characters than the incoming mail.
Comment 6 Xabier Rodríguez Calvar 2008-05-09 17:25:17 UTC
Maybe this is related to bug 336291 . I don't know if password should be tied to server or account, but it should distinguish for protocol or at least outgoing or incoming.
Comment 7 Matthew Barnes 2008-05-10 10:45:58 UTC
I think I see what's happening.  Our keyring logic stores passwords by username and server only.  Not protocol.  So for example:

   imap://mbarnes@mail.boston.redhat.com/

   The password gets stored under
   Username: mbarnes  Server: mail.boston.redhat.com

and

   smtp://mbarnes@mail.boston.redhat.com/

   The password also gets stored under
   Username: mbarnes  Server: mail.boston.redhat.com

Only the "displayed name" field in the keyring retains the protocol.  But
that field is intended as free-form text and we don't do lookups based on it.
So if the passwords are different they would step on each other constantly.

The tricky part will be fixing this so as not to force everyone (whether
they're affected by this bug or not) to re-enter their passwords.  We'll have
to fall back to a user/server match if a user/server/protocol match fails,
for the sake of backward-compatibility.
Comment 8 Matthew Barnes 2008-05-10 11:45:36 UTC
*** Bug 521611 has been marked as a duplicate of this bug. ***
Comment 9 Matthew Barnes 2008-05-10 11:49:26 UTC
Created attachment 110677 [details] [review]
Proposed patch

This patch stores keyring passwords with username/server/protocol attributes, and adds the appropriate backward-compatibility cruft so we can still find passwords with username/server attributes only.
Comment 10 Matthew Barnes 2008-05-10 11:52:14 UTC
Adjusting product, version and summary.
Comment 11 Matthew Barnes 2008-05-11 20:35:13 UTC
*** Bug 532643 has been marked as a duplicate of this bug. ***
Comment 12 Matthew Barnes 2008-05-12 20:02:42 UTC
*** Bug 523522 has been marked as a duplicate of this bug. ***
Comment 13 Srinivasa Ragavan 2008-05-19 04:20:00 UTC
Please commit it.
Comment 14 Matthew Barnes 2008-05-19 14:25:47 UTC
Committed to trunk (revision 8812) and gnome-2-22 (revision 8813).
Comment 15 Matthew Barnes 2008-06-07 12:25:42 UTC
*** Bug 513667 has been marked as a duplicate of this bug. ***