After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 354823 - Crash in gnome_vfs_get_volume_monitor
Crash in gnome_vfs_get_volume_monitor
Status: RESOLVED FIXED
Product: gnome-vfs
Classification: Deprecated
Component: Volume and drive handling
2.16.x
Other All
: Urgent critical
: ---
Assigned To: gnome-vfs maintainers
gnome-vfs maintainers
: 354886 355001 355022 355076 355102 355205 355361 355403 355603 355621 355735 355736 355794 355925 355930 355944 355949 356002 356123 356262 356308 356313 356332 356468 356472 356526 356566 356771 357035 357117 357339 357356 357358 358197 358889 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-09-07 17:48 UTC by stephan
Modified: 2006-10-17 14:49 UTC
See Also:
GNOME target: 2.16.x
GNOME version: 2.15/2.16


Attachments
workaround for missing dbus session (710 bytes, patch)
2006-09-21 15:44 UTC, Daniel Gryniewicz
none Details | Review
prevent crashing when no session bus is running (1.32 KB, patch)
2006-10-06 08:42 UTC, Frederic Crozat
none Details | Review

Description stephan 2006-09-07 17:48:09 UTC
Version: 2.15.9

What were you doing when the application crashed?



Distribution: Gentoo Base System version 1.12.4
Gnome Release: 2.15.92 2006-09-01 (Gentoo)
BugBuddy Version: 2.15.92

Memory status: size: 38502400 vsize: 0 resident: 38502400 share: 0 rss: 18604032 rss_rlim: 0
CPU usage: start_time: 1157651257 rtime: 0 utime: 115 stime: 0 cutime:108 cstime: 0 timeout: 7 it_real_value: 0 frequency: 0

Backtrace was generated from '/usr/bin/gedit'

(no debugging symbols found)
Using host libthread_db library "/lib/libthread_db.so.1".
(no debugging symbols found)
[Thread debugging using libthread_db enabled]
[New Thread -1216588112 (LWP 11531)]
0xffffe410 in __kernel_vsyscall ()

Thread 1 (Thread -1216588112 (LWP 11531))

  • #0 __kernel_vsyscall
  • #1 __waitpid_nocancel
    from /lib/libpthread.so.0
  • #2 gnome_gtk_module_info_get
    from /usr/lib/libgnomeui-2.so.0
  • #3 <signal handler called>
  • #4 dbus_connection_send_with_reply
    from /usr/lib/libdbus-1.so.2
  • #5 dbus_connection_send_with_reply_and_block
    from /usr/lib/libdbus-1.so.2
  • #6 gnome_vfs_volume_monitor_client_shutdown_private
    from /usr/lib/libgnomevfs-2.so.0
  • #7 gnome_vfs_volume_monitor_client_get_type
    from /usr/lib/libgnomevfs-2.so.0
  • #8 g_type_create_instance
    from /usr/lib/libgobject-2.0.so.0
  • #9 g_object_set
    from /usr/lib/libgobject-2.0.so.0
  • #10 g_object_newv
    from /usr/lib/libgobject-2.0.so.0
  • #11 g_object_new_valist
    from /usr/lib/libgobject-2.0.so.0
  • #12 g_object_new
    from /usr/lib/libgobject-2.0.so.0
  • #13 gnome_vfs_volume_monitor_emit_pre_unmount
    from /usr/lib/libgnomevfs-2.so.0
  • #14 gnome_vfs_get_volume_monitor
    from /usr/lib/libgnomevfs-2.so.0
  • #15 fs_module_create
    from /usr/lib/gtk-2.0/2.10.0/filesystems/libgnome-vfs.so
  • #16 g_type_create_instance
    from /usr/lib/libgobject-2.0.so.0
  • #17 g_object_set
    from /usr/lib/libgobject-2.0.so.0
  • #18 g_object_newv
    from /usr/lib/libgobject-2.0.so.0
  • #19 g_object_new_valist
    from /usr/lib/libgobject-2.0.so.0
  • #20 g_object_new
    from /usr/lib/libgobject-2.0.so.0
  • #21 gtk_file_system_gnome_vfs_new
    from /usr/lib/gtk-2.0/2.10.0/filesystems/libgnome-vfs.so
  • #22 fs_module_create
    from /usr/lib/gtk-2.0/2.10.0/filesystems/libgnome-vfs.so
  • #23 gtk_file_selection_set_filename
    from /usr/lib/libgtk-x11-2.0.so.0
  • #24 gtk_file_selection_set_filename
    from /usr/lib/libgtk-x11-2.0.so.0
  • #25 gtk_file_chooser_button_new
    from /usr/lib/libgtk-x11-2.0.so.0
  • #26 g_object_set
    from /usr/lib/libgobject-2.0.so.0
  • #27 gtk_file_chooser_button_new
    from /usr/lib/libgtk-x11-2.0.so.0
  • #28 g_object_newv
    from /usr/lib/libgobject-2.0.so.0
  • #29 g_object_new_valist
    from /usr/lib/libgobject-2.0.so.0
  • #30 g_object_new
    from /usr/lib/libgobject-2.0.so.0
  • #31 gtk_file_chooser_button_new
    from /usr/lib/libgtk-x11-2.0.so.0
  • #32 gtk_file_chooser_widget_new
    from /usr/lib/libgtk-x11-2.0.so.0
  • #33 g_object_newv
    from /usr/lib/libgobject-2.0.so.0
  • #34 g_object_new_valist
    from /usr/lib/libgobject-2.0.so.0
  • #35 g_object_new
    from /usr/lib/libgobject-2.0.so.0
  • #36 gtk_file_chooser_dialog_new
    from /usr/lib/libgtk-x11-2.0.so.0
  • #37 g_object_newv
    from /usr/lib/libgobject-2.0.so.0
  • #38 g_object_new_valist
    from /usr/lib/libgobject-2.0.so.0
  • #39 g_object_new
    from /usr/lib/libgobject-2.0.so.0
  • #40 gedit_file_chooser_dialog_new
  • #41 _gedit_cmd_file_open
  • #42 g_cclosure_marshal_VOID__VOID
    from /usr/lib/libgobject-2.0.so.0
  • #43 g_closure_invoke
    from /usr/lib/libgobject-2.0.so.0
  • #44 g_signal_chain_from_overridden
    from /usr/lib/libgobject-2.0.so.0
  • #45 g_signal_emit_valist
    from /usr/lib/libgobject-2.0.so.0
  • #46 g_signal_emit
    from /usr/lib/libgobject-2.0.so.0
  • #47 gtk_widget_get_action
    from /usr/lib/libgtk-x11-2.0.so.0
  • #48 gtk_action_activate
    from /usr/lib/libgtk-x11-2.0.so.0
  • #49 g_cclosure_marshal_VOID__VOID
    from /usr/lib/libgobject-2.0.so.0
  • #50 g_closure_invoke
    from /usr/lib/libgobject-2.0.so.0
  • #51 g_signal_chain_from_overridden
    from /usr/lib/libgobject-2.0.so.0
  • #52 g_signal_emit_valist
    from /usr/lib/libgobject-2.0.so.0
  • #53 g_signal_emit_by_name
    from /usr/lib/libgobject-2.0.so.0
  • #54 gtk_tool_button_new_from_stock
    from /usr/lib/libgtk-x11-2.0.so.0
  • #55 g_cclosure_marshal_VOID__VOID
    from /usr/lib/libgobject-2.0.so.0
  • #56 g_closure_invoke
    from /usr/lib/libgobject-2.0.so.0
  • #57 g_signal_chain_from_overridden
    from /usr/lib/libgobject-2.0.so.0
  • #58 g_signal_emit_valist
    from /usr/lib/libgobject-2.0.so.0
  • #59 g_signal_emit
    from /usr/lib/libgobject-2.0.so.0
  • #60 gtk_button_clicked
    from /usr/lib/libgtk-x11-2.0.so.0
  • #61 gtk_button_set_alignment
    from /usr/lib/libgtk-x11-2.0.so.0
  • #62 g_cclosure_marshal_VOID__VOID
    from /usr/lib/libgobject-2.0.so.0
  • #63 g_value_set_boxed
    from /usr/lib/libgobject-2.0.so.0
  • #64 g_closure_invoke
    from /usr/lib/libgobject-2.0.so.0
  • #65 g_signal_chain_from_overridden
    from /usr/lib/libgobject-2.0.so.0
  • #66 g_signal_emit_valist
    from /usr/lib/libgobject-2.0.so.0
  • #67 g_signal_emit
    from /usr/lib/libgobject-2.0.so.0
  • #68 gtk_button_released
    from /usr/lib/libgtk-x11-2.0.so.0
  • #69 gtk_button_released
    from /usr/lib/libgtk-x11-2.0.so.0
  • #70 gtk_marshal_BOOLEAN__VOID
    from /usr/lib/libgtk-x11-2.0.so.0
  • #71 g_value_set_boxed
    from /usr/lib/libgobject-2.0.so.0
  • #72 g_closure_invoke
    from /usr/lib/libgobject-2.0.so.0
  • #73 g_signal_chain_from_overridden
    from /usr/lib/libgobject-2.0.so.0
  • #74 g_signal_emit_valist
    from /usr/lib/libgobject-2.0.so.0
  • #75 g_signal_emit
    from /usr/lib/libgobject-2.0.so.0
  • #76 gtk_widget_get_default_style
    from /usr/lib/libgtk-x11-2.0.so.0
  • #77 gtk_propagate_event
    from /usr/lib/libgtk-x11-2.0.so.0
  • #78 gtk_main_do_event
    from /usr/lib/libgtk-x11-2.0.so.0
  • #79 gdk_add_client_message_filter
    from /usr/lib/libgdk-x11-2.0.so.0
  • #80 g_main_context_dispatch
    from /usr/lib/libglib-2.0.so.0
  • #81 g_main_context_check
    from /usr/lib/libglib-2.0.so.0
  • #82 g_main_loop_run
    from /usr/lib/libglib-2.0.so.0
  • #83 gtk_main
    from /usr/lib/libgtk-x11-2.0.so.0
  • #84 main
  • #0 __kernel_vsyscall

Comment 1 Paolo Maggi 2006-09-07 18:02:55 UTC
Thanks for taking the time to report this bug.
This bug report isn't very useful because it doesn't describe the bug well. If you have time and can still reproduce the bug, please read http://bugzilla.gnome.org/bug-HOWTO.html and add a description of how to reproduce this bug.

You'll also need to add a stack trace; please see http://live.gnome.org/GettingTraces for more information about how to do so.

It seems a crash in gnome-vfs or on the gnome-vfs backend of the file chooser.
Comment 2 Rob Bradford 2006-09-08 16:13:40 UTC
*** Bug 354886 has been marked as a duplicate of this bug. ***
Comment 3 Mariano Suárez-Alvarez 2006-09-08 22:47:56 UTC
*** Bug 355022 has been marked as a duplicate of this bug. ***
Comment 4 Paolo Maggi 2006-09-09 12:41:46 UTC
*** Bug 355102 has been marked as a duplicate of this bug. ***
Comment 5 Paolo Maggi 2006-09-09 12:43:02 UTC
*** Bug 355076 has been marked as a duplicate of this bug. ***
Comment 6 Paolo Maggi 2006-09-09 12:45:48 UTC
All the duplicates of this crash happen on Gentoo.

What optimisations did you use when you built GNOME libraries and dbus?
Note that using optimisation higher than -O2 is not supported.
Comment 7 Christian Kirbach 2006-09-09 16:22:58 UTC
*** Bug 355001 has been marked as a duplicate of this bug. ***
Comment 8 Christian Kirbach 2006-09-09 16:24:49 UTC
note that it crashes in dbus
Comment 9 Paolo Maggi 2006-09-09 18:05:12 UTC
I suspect this crash is due to some problem introduced by the compiler when compiling with aggressive optimization switches.

In fact all the crashes we are observing are on Gentoo.
Comment 10 Fabio Bonelli 2006-09-10 07:24:15 UTC
*** Bug 355205 has been marked as a duplicate of this bug. ***
Comment 11 Fabio Bonelli 2006-09-12 08:07:03 UTC
*** Bug 355403 has been marked as a duplicate of this bug. ***
Comment 12 Fabio Bonelli 2006-09-12 08:08:13 UTC
*** Bug 355361 has been marked as a duplicate of this bug. ***
Comment 13 Karsten Bräckelmann 2006-09-12 16:45:48 UTC
*** Bug 355603 has been marked as a duplicate of this bug. ***
Comment 14 Karsten Bräckelmann 2006-09-12 16:48:34 UTC
Still, all duplicates are on Gentoo.  Possibly NOTGNOME.
Comment 15 Adam Caldwell 2006-09-12 16:56:07 UTC
Dbus and gnome libs were compiled using the flags:

-march=athlon64 -O2 -pipe

as was everything else on the system, using gcc 4.1.1.

I can confirm this crash happens 100% of the time I run gedit as root, but never seems to happen running as a normal user.
Comment 16 Adam Caldwell 2006-09-12 16:57:49 UTC
Also, the following warning appears when launching gedit (again, only as root):

(gedit:31790): GnomeUI-WARNING **: While connecting to session manager:
Authentication Rejected, reason : None of the authentication protocols specified are supported and host-based authentication failed.

And another warning upon trying to open a file, right before the crash:

(gedit:31790): libgnomevfs-WARNING **: Failed to open session DBUS connection: No reply within specified time
Volume monitoring will not work.
Comment 17 Steve Frécinaux 2006-09-12 17:07:00 UTC
Might be a side effect of gnomevfs migration to D-Bus: you don't have a session daemon running for root when you use `sudo`.
Comment 18 Steve Frécinaux 2006-09-12 18:02:35 UTC
*** Bug 355621 has been marked as a duplicate of this bug. ***
Comment 19 Mike Auty 2006-09-12 22:40:40 UTC
Hi, I'm also getting this.  I'm also on Gentoo.  I can recreate this easily and reliably in pretty much any program that uses a standard file chooser dialog.  I haven't managed to test it as any user other than root.  I have two systems that were compiled roughly as follows:

Portage 2.1.1 (default-linux/x86/2006.0, gcc-4.1.1/vanilla, glibc-2.4-r3, 2.6.17-gentoo-r7 i686)
=================================================================
System uname: 2.6.17-gentoo-r7 i686 AMD Athlon(tm) 64 Processor 3400+
ccache version 2.4 [enabled]
dev-util/ccache:     2.4-r2
sys-apps/sandbox:    1.2.18.1
sys-devel/autoconf:  2.13, 2.60
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2
sys-devel/binutils:  2.17
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.17
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=athlon-xp -fomit-frame-pointer -pipe"
CHOST="i686-pc-linux-gnu"
CXXFLAGS="-O2 -march=athlon-xp -fomit-frame-pointer -pipe"
LDFLAGS="-Wl,--as-needed"
LINGUAS="en_GB en"
MAKEOPTS="-j1"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, PORTAGE_RSYNC_EXTRA_OPTS

I've tried to cut this down to just the pertinent information.  My other box was built with CFLAGS = CXXFLAGS = "-mtune=pentium4 -march=pentium4 -O2 -fomit-frame-pointer -pipe -msse3", since it's a dual-core Intel.

The current version of dbus I'm using is 0.62.  The issue goes away if I launch the affected program using dbus-launch.

If this is a compilation issue, the two features of my build setup that cause me the greatest headaches are the LDFLAGS set to --as-needed (which should compile each binary pulling in only the libraries that are specifically called, rather than any that are mentioned) and the ccache (but this has only ever caused a couple of problems in the past).

If there's any further information I can provide to help figure out this problem, please let me know, I'd really like to see it solved...
Comment 20 Mike Auty 2006-09-12 22:43:48 UTC
Also, is there any chance of re-opening this, or rephrasing the specific information that's required?  At the moment, this bug is difficult to find (I expected it to be an open bug) and yet it appears quite a common one...
Comment 21 Christian Kirbach 2006-09-13 07:22:03 UTC
>(gedit:31790): libgnomevfs-WARNING **: Failed to open session DBUS connection:
>No reply within specified time
>Volume monitoring will not work.

>The issue goes away if I launch the affected program using dbus-launch.

this is a setup issue then, I strongly assume. dbus-launch sets the DBUS_SESSION_BUS_ADDRESS environment variable.

However I cannot reproduce the crash unsetting DBUS_SESSION_BUS_ADDRESS but the last statement conveys to me that we seem to have a setup problem. The fact that this only affects Gentoo underlines this.
Comment 22 Mike Auty 2006-09-13 09:41:07 UTC
OK, unfortunately I don't know what the normal start-up procedure is for a program, so could someone not experiencing this issue post their experiences with the following:

Start up X as a normal user.
Start up gnome-terminal (probably run as a login shell)
Launch gedit, click on open, have it all work fine.
Then exit gedit, run "su -" and login as root.
Ensure there is no dbus-session ("ps aux | grep dbus | grep root" should be empty).
Then run gedit again, then click on open.

What I'm interested in is whether in standard builds, dbus is automatically launched, whether the gnome-vfs still spits out the warning about dbus not being found.

I'm also interested in what calls gnome-vfs attempts to make in volume_monitor_client_shutdown_private, since it seems clear these make dbus calls, which end up breaking:

  • #3 <signal handler called>
  • #4 dbus_connection_send_with_reply
    from /usr/lib/libdbus-1.so.2
  • #5 dbus_connection_send_with_reply_and_block
    from /usr/lib/libdbus-1.so.2
  • #6 gnome_vfs_volume_monitor_client_shutdown_private
    from /usr/lib/libgnomevfs-2.so.0
  • #7 gnome_vfs_volume_monitor_client_get_type
    from /usr/lib/libgnomevfs-2.so.0

Having taken a quick dive into the source code, I can't figure out how dbus_connection_send_with_reply_and_block can be sent out, since the dbus_conn should always be NULL if there's no dbus-session running?  If there is a dbus-session running, which one is it trying to latch onto?  I also can't follow how gnome_vfs_volume_monitor_emit_pre_unmount ever gets called?

Could someone with a bit more experience in the area look into the code and stacktrace to help trace the problem component please?
Comment 23 Fabio Bonelli 2006-09-13 09:55:27 UTC
*** Bug 355735 has been marked as a duplicate of this bug. ***
Comment 24 Fabio Bonelli 2006-09-13 09:55:48 UTC
*** Bug 355736 has been marked as a duplicate of this bug. ***
Comment 25 Karsten Bräckelmann 2006-09-13 15:05:23 UTC
*** Bug 355794 has been marked as a duplicate of this bug. ***
Comment 26 Karsten Bräckelmann 2006-09-14 10:31:46 UTC
*** Bug 355930 has been marked as a duplicate of this bug. ***
Comment 27 Karsten Bräckelmann 2006-09-14 10:31:50 UTC
*** Bug 355925 has been marked as a duplicate of this bug. ***
Comment 28 Karsten Bräckelmann 2006-09-14 12:05:42 UTC
*** Bug 355944 has been marked as a duplicate of this bug. ***
Comment 29 Karsten Bräckelmann 2006-09-14 12:29:05 UTC
*** Bug 355949 has been marked as a duplicate of this bug. ***
Comment 30 Karsten Bräckelmann 2006-09-14 18:57:34 UTC
*** Bug 356002 has been marked as a duplicate of this bug. ***
Comment 31 Karsten Bräckelmann 2006-09-15 12:57:25 UTC
*** Bug 356123 has been marked as a duplicate of this bug. ***
Comment 32 jduby229 2006-09-15 13:02:29 UTC
CFLAGS="-march=athlon64 -O2 "
CHOST="x86_64-pc-linux-gnu"
CXXFLAGS="${CFLAGS}"
MAKEOPTS="-j3"
#ACCEPT_KEYWORDS="~amd64"
VIDEO_CARDS="vesa"
INPUT_DEVICES="keyboard mouse joystick"
LINGUAS="en"

This is the important part of my make.conf. I also get this problem....

I've read through this and it seems that it has been nailed as a setup issue.. Is there anyway to contact the Gentoo Gnome team to see if they are aware of this problem? Or have they already been informed?
Comment 33 Karsten Bräckelmann 2006-09-16 14:12:43 UTC
*** Bug 356262 has been marked as a duplicate of this bug. ***
Comment 34 Karsten Bräckelmann 2006-09-16 19:52:41 UTC
*** Bug 356308 has been marked as a duplicate of this bug. ***
Comment 35 Karsten Bräckelmann 2006-09-16 20:46:33 UTC
*** Bug 356313 has been marked as a duplicate of this bug. ***
Comment 36 Karsten Bräckelmann 2006-09-16 23:04:49 UTC
*** Bug 356332 has been marked as a duplicate of this bug. ***
Comment 37 Mike Auty 2006-09-16 23:36:50 UTC
Given the sheer number of duplicates that are coming it, it would be worthwhile trying to track down this bug simply to ease the load on bugzilla.  As such, I'd like to ask again that the status be reopened, so that we can get more people looking at the bug?

It appears as though there's a spontaneous call to gnome_vfs_volume_monitor_emit_pre_unmount which shouldn't be possible without a dbus connection, yet it always seems to occur right before the crash, even though a session dbus isn't running.  As soon as it is running it works fine (presumably because this call is working on a valid dbus conenction).  Unfortunately, we're going to need a little help from someone who knows the code better to help understand why.

As ever I'm happy to test out any patches or code modifications anyone is willing to offer that might fix this problem, and I'll report as much information as I can on the tests.  I'd like to see a fix for this go into at least portage, if not upstream, as soon as possible...
Comment 38 Paolo Maggi 2006-09-17 12:21:42 UTC
There are about 30 duplicates of this bug and all on Gentoo
May be the gentoo guys should try to give a look at it.
Comment 39 Karsten Bräckelmann 2006-09-18 01:21:49 UTC
*** Bug 356472 has been marked as a duplicate of this bug. ***
Comment 40 Karsten Bräckelmann 2006-09-18 01:24:44 UTC
*** Bug 356468 has been marked as a duplicate of this bug. ***
Comment 41 Karsten Bräckelmann 2006-09-18 12:27:25 UTC
*** Bug 356526 has been marked as a duplicate of this bug. ***
Comment 42 Karsten Bräckelmann 2006-09-18 16:14:54 UTC
*** Bug 356566 has been marked as a duplicate of this bug. ***
Comment 43 Karsten Bräckelmann 2006-09-19 17:46:37 UTC
*** Bug 356771 has been marked as a duplicate of this bug. ***
Comment 44 Karsten Bräckelmann 2006-09-21 14:06:54 UTC
*** Bug 357035 has been marked as a duplicate of this bug. ***
Comment 45 Daniel Gryniewicz 2006-09-21 14:58:03 UTC
It would have been nice if at least one of these people had actually submitted a gentoo bug for this...

At any rate, it's easily reproducable here, so I'll look into it.
Comment 46 Daniel Gryniewicz 2006-09-21 15:44:13 UTC
Color me confused, but there doesn't appear to be any protection for lack of DBUS connection in gnome_vfs_volume_monitor_client_init().  I've added the tiny patch attached, and this problem goes away for me; gedit run via sudo workes fine, edits and changes files, and doesn't crash.

I doubt this is the right solution, but why aren't others hitting this problem?  It *should* happen anywhere there's no dbus connection?  Is something supposed to be auto-spawning a dbus session when one doesn't exist that gentoo is missing?
Comment 47 Daniel Gryniewicz 2006-09-21 15:44:53 UTC
Created attachment 73148 [details] [review]
workaround for missing dbus session
Comment 48 Karsten Bräckelmann 2006-09-21 21:54:23 UTC
*** Bug 357117 has been marked as a duplicate of this bug. ***
Comment 49 Karsten Bräckelmann 2006-09-23 15:56:15 UTC
*** Bug 357339 has been marked as a duplicate of this bug. ***
Comment 50 Karsten Bräckelmann 2006-09-23 18:41:07 UTC
*** Bug 357358 has been marked as a duplicate of this bug. ***
Comment 51 Karsten Bräckelmann 2006-09-23 18:41:22 UTC
*** Bug 357356 has been marked as a duplicate of this bug. ***
Comment 52 Benoît Dejean 2006-09-28 21:18:05 UTC
*** Bug 358197 has been marked as a duplicate of this bug. ***
Comment 53 Karsten Bräckelmann 2006-10-02 00:03:26 UTC
*** Bug 358889 has been marked as a duplicate of this bug. ***
Comment 54 André Klapper 2006-10-05 14:29:01 UTC
gicmo, christian:
this bites a lot of users. simple workaround attached, please take a look at it.

marking this one as a GNOME 2.16.x target, too many dups.
Comment 55 Christian Neumair 2006-10-05 15:04:04 UTC
Andre: I totally agree with you. Thanks for coming up with a patch.
Let's decide Alex how exactly he wants the code to be laid out, though. 
Comment 56 André Klapper 2006-10-05 15:10:34 UTC
christian: thanks of the quick responses (in general). :-)
i assume that you're going to poke alex as he isn't on the CC list, thanks in advance.
Comment 57 Frederic Crozat 2006-10-06 08:42:32 UTC
Created attachment 74119 [details] [review]
prevent crashing when no session bus is running

this patch (included in Mandriva Linux 2007.0) prevents crash when no session bus is running (for instance when logging on a system with ssh and running a gnome application there).

It also disable the "failed to open dbus connection" warning since there is no point is giving this information to users (they won't be able to do anything for that).

Since future dbus version will have autolaunch, if gnome-vfs requires such version, enabling back the warning will be interesting.
Comment 58 André Klapper 2006-10-07 15:53:39 UTC
CC'ing alex to get one of these trivial patches in asap - too many crash reports already about this.
Comment 59 Alexander Larsson 2006-10-17 14:19:51 UTC
I commited Frederics patch. Thanks guys.
Comment 60 André Klapper 2006-10-17 14:49:39 UTC
great, thanks for fixing this. :-)