After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 354304 - Change close button flashing on chat tabs to show all the time
Change close button flashing on chat tabs to show all the time
Status: RESOLVED FIXED
Product: gossip
Classification: Deprecated
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Gossip Maintainers
Gossip Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-09-04 16:22 UTC by Guillaume Desmottes
Modified: 2006-09-07 18:45 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
proposed patch (3.73 KB, patch)
2006-09-04 16:34 UTC, Xavier Claessens
committed Details | Review

Description Guillaume Desmottes 2006-09-04 16:22:27 UTC
IMHO it's not a good idea to remove tab's closing button when the cursor leaves the window.
- It's not consistent with others GNOME applications : Epiphany, gnome-terminal.
- It's disturbing. If you don't pay attention, you have the feeling that this button randomly appear/disappear.
- It's not really useful. We don't gain a lot of space, and when we have this extra space, there is good chance than the user is watching another application.
- It's against the KISS principle. :-)
Comment 1 Xavier Claessens 2006-09-04 16:34:04 UTC
Created attachment 72211 [details] [review]
proposed patch

I agree, that's something I dislike in gossip.

Happy to see I'm not the only one :-)
Comment 2 Richard Hult 2006-09-05 07:32:28 UTC
FWIW, I also agree with this. We tried it to save space but I don't think it's working very well:

1. The implementation is buggy (and is a bit tricky to get right since we don't always get enter/leave for example when switching desktops).

2. The space is not really saved, since when you use the window it has focus, like you say.

3. It causes a lot of annoying flickering when moving in and out of the window, especially when using Ubuntu where the close icon is very bright and visible.

So, since there is no better alternative, I vote for reverting the current behavior at least in the meantime since it doesn't really work.
Comment 3 Martyn Russell 2006-09-07 18:45:57 UTC
Committed, thanks ;)