After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 353625 - Presentation mode: type page number to jump there
Presentation mode: type page number to jump there
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
0.6.x
Other All
: Urgent enhancement
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-08-31 00:58 UTC by David Menestrina
Modified: 2006-12-24 12:54 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Sample patch off of evince-0.5.2 (3.49 KB, patch)
2006-08-31 01:11 UTC, David Menestrina
none Details | Review

Description David Menestrina 2006-08-31 00:58:14 UTC
Both Powerpoint and OpenOffice.org Impress have the feature that in slideshow/presentation mode, you can type in the number of a slide, then hit Enter and it will jump to the slide number you typed in.  Evince should do the same.

(I searched for this feature on bugzilla but I couldn't find it, so I filed it myself.)
Comment 1 David Menestrina 2006-08-31 01:11:31 UTC
Created attachment 71942 [details] [review]
Sample patch off of evince-0.5.2

Added a sample patch to approximate the behavior.

Potential issues with the patch:
1) The Enter/Return keys can't be trapped by the EvView widget because the main widget already handles them.  This patch allows you to use the letter "g" (for Go!) instead of Enter/Return.
2) No attempt is made to restrict the behavior to presentation mode.  Maybe it would be useful outside of presentation mode, who knows?
Comment 2 Christian Persch 2006-08-31 12:01:48 UTC
+	else if (event->keyval == GDK_g || event->keyval == GDK_Return || event->keyval == GDK_KP_Enter)

You should also check for GDK_ISO_Enter here.
Comment 3 Nickolay V. Shmyrev 2006-09-05 08:22:32 UTC
Nice enchancement anyhow. But probably we need to show an entry like in typeahead
Comment 4 David Menestrina 2006-09-05 16:02:28 UTC
(In reply to comment #3)
> But probably we need to show an entry like in typeahead

I'd consider this a good addition, although not required functionality, since neither powerpoint nor openoffice.org do that.

Comment 5 Wouter Bolsterlee (uws) 2006-12-15 09:28:52 UTC
That's not a valid argument, Evince can just do better ;)
Comment 6 Carlos Garcia Campos 2006-12-22 17:51:38 UTC
I've just fixed it in cvs head. Finally, it uses a popup window with an entry. 
Comment 7 Wouter Bolsterlee (uws) 2006-12-24 12:54:01 UTC
2006-12-24  Wouter Bolsterlee  <wbolster@cvs.gnome.org>

        * shell/ev-view.c: (ev_view_goto_window_create):

        Show "Jump to page" label in the page jumping popup in
        presentation mode instead of just a GtkEntry.