After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 353234 - audiorate preserves DISCONT on buffers
audiorate preserves DISCONT on buffers
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.10
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-08-28 12:59 UTC by Michael Smith
Modified: 2006-08-28 16:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Michael Smith 2006-08-28 12:59:18 UTC 
Audiorate may receive buffers with DISCONT set. Much of the point of audiorate is to preserve a 'perfect' stream with no discontinuities - so in this case, it should clear the DISCONT flag before pushing the buffer.

This is causing vorbisenc's discont detection to trigger.
Comment 1 Wim Taymans 2006-08-28 16:09:20 UTC 
This should fix it:

        * gst/audiorate/gstaudiorate.c: (gst_audio_rate_reset),
        (gst_audio_rate_setcaps), (gst_audio_rate_init),
        (gst_audio_rate_sink_event), (gst_audio_rate_src_event),
        (gst_audio_rate_chain), (gst_audio_rate_change_state):
        Fix audiorate some more.
        Reset and resync counters on flush and READY.
        Handle the DISCONT flag correctly.
        Use GstSegment to track position.
        Fail when not negotiated.
        Fixes #353234.