GNOME Bugzilla – Bug 353213
planner does not compile with libgda 1.3.91
Last modified: 2006-10-04 14:36:58 UTC
Please describe the problem: Several gda functions, like gda_connection_execute_single_command take now more parameters than in older versions. I will try to provide the patch that I use to make it working properly. Steps to reproduce: 1. install libgda 1.3.91 2. try to compile Actual results: Expected results: Does this happen every time? Other information:
Created attachment 71762 [details] [review] patch to make it working with gda here I am not sure if really every change is needed, but thats the way other people did it too.
patch committed and included in 0.14.1 release
Adding this patch makes a hard dependancy on API *UNSTABLE* libgda version. There is no single distribution shipping libgda >= 1.3.x/1.9.x. What it a purpose of doing that? IMO this patch should have additional #ifdef LIBGDA2 definitions/configure checks to make build against unstable libgda *conditional*. Applying it in current form is very questionable.
At least here (on SuSE 10.1/10.2) I have libgda 1.3.91 installed. So far to the "no single distribution" theory. But nevertheless I agree with the patch beeing made conditionally, so it works for all versions. Unfortunately I don't know much about the system to do it, so I cannot provide a patch...
suse ships unstable, pre-alfa stage libs? oops. I think in configure.in you can add additional check for libgda-2: PKG_CHECK_MODULES(GDA2, libgda-2 >= 1.3.x) [...] AM_CONDITIONAL(HAVE_GDA2, test x$use_gda = xyes) and in source files something like: #ifdef HAVE_GDA2 res = gda_connection_execute_single_command (con, cmd, NULL, &error); #else res = gda_connection_execute_single_command (con, cmd, NULL); #endif The next problem is: libgda-1.9.10x introduces even more API changes, so propably your changes are only usuable for suse 10.1/10.2 users.
Whatever that patch was supposed to fix, it actual BREAKS the build using older GDA versions: checking for gconftool-2... /usr/bin/gconftool-2 Using config source xml:merged:/etc/gconf/gconf.xml.defaults for schema installation Using $(sysconfdir)/gconf/schemas as install directory for schema files checking pkg-config is at least version 0.9.0... yes checking for GDA... configure: error: Package requirements (libgda-2.0 >= 1.0) were not met: No package 'libgda-2.0' found Consider adjusting the PKG_CONFIG_PATH environment variable if you installed software in a non-standard prefix. Alternatively, you may set the environment variables GDA_CFLAGS and GDA_LIBS to avoid the need to call pkg-config. See the pkg-config man page for more details. make: *** [config.status] Error 1 pbuilder: Failed autobuilding of package ### executing tmp/hooks/C10shell ### root@build:/# dpkg -l libgda* Desired=Unknown/Install/Remove/Purge/Hold | Status=Not/Installed/Config-files/Unpacked/Failed-config/Half-installed |/ Err?=(none)/Hold/Reinst-required/X=both-problems (Status,Err: uppercase=bad) ||/ Name Version Description +++-=====================-=====================-========================================================== un libgda-common <none> (no description available) un libgda2-1 <none> (no description available) ii libgda2-3 1.2.3-2 GNOME Data Access library for GNOME2 un libgda2-bin <none> (no description available) ii libgda2-common 1.2.3-2 Common files for GNOME Data Access library for GNOME2 ii libgda2-dev 1.2.3-2 Development files for GNOME Data Access library for GNOME2 un libgda2-doc <none> (no description available) root@build:/# dpkg -L libgda2-dev libgda2-common libgda2-3 | grep pc /usr/lib/pkgconfig/libgda.pc root@build:/#
Sorry, the above change is intrusive enough to prevent any further release on Debian and Ubuntu. I tried reverting to no avail: the above patch and what went into 0.14.1 diverge enough that changes to libplanner/mrp-sql.c won't revert. It would REALLY be a good idea to consult with Planner maintainers for major distributions, before committing that sort of intrusive change, in the future. Meanwhile, it would be appreciated if this change was reverted immediately and a new 0.14.2 released ASAP.