After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 353163 - layout not redrawing properly
layout not redrawing properly
Status: RESOLVED FIXED
Product: libgnomekbd
Classification: Core
Component: Drawing
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libgnomekbd maintainers
Sergey V. Udaltsov
Depends on:
Blocks:
 
 
Reported: 2006-08-28 02:38 UTC by Matthias Clasen
Modified: 2007-12-16 13:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.25 KB, patch)
2006-08-28 03:42 UTC, Matthias Clasen 		none Details | Review
updated patch (1.31 KB, patch)
2007-01-24 20:51 UTC, Matthias Clasen 		none Details | Review
updated to 2.21.4 (1.33 KB, patch)
2007-12-16 01:36 UTC, Matthias Clasen 		none Details | Review

Description Matthias Clasen 2006-08-28 02:38:35 UTC 
when keys are pressed, libkbdraw just redraws the pressed button, possibly 
overdrawing overlapping doodads. This can be seen e.g. with the Thinkpad layouts,
when pressing the g, h, b keys.
Comment 1 Matthias Clasen 2006-08-28 03:42:55 UTC 
Created attachment 71745 [details] [review]
patch

A simple-minded fix; simply redraw all later doodads, when a key is redrawn
Comment 2 Sergey V. Udaltsov 2006-08-29 23:21:27 UTC 
Ghm, I am not really excited about this way of patching. Also, it seems it does not guarantee the quality - if some shape (outline) doodads change the color from non-transparent to transparent - and some preceding doodads are not redrawn.
Comment 3 Matthias Clasen 2006-08-30 05:02:07 UTC 
yes, as i said, this is just the simplest possible patch to get the thinkpad 
mouse pin to redraw after key presses.
Comment 4 Matthias Clasen 2007-01-24 20:51:15 UTC 
Created attachment 81116 [details] [review]
updated patch

Same patch, ported to libgnomekbd
Comment 5 Matthias Clasen 2007-12-16 01:36:01 UTC 
Created attachment 101035 [details] [review]
updated to 2.21.4
Comment 6 Sergey V. Udaltsov 2007-12-16 13:15:13 UTC 
Ok, you pushed me hard enough. Committed;) Thanks.