After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 352840 - Version string not expanded in .desktop file (bug buddy section)
Version string not expanded in .desktop file (bug buddy section)
Status: RESOLVED FIXED
Product: gnome-power-manager
Classification: Deprecated
Component: gnome-power-preferences
2.15.x
Other All
: Normal normal
: ---
Assigned To: GNOME Power Manager Maintainer(s)
GNOME Power Manager Maintainer(s)
Depends on:
Blocks: 348827
 
 
Reported: 2006-08-25 12:36 UTC by Stephane Loeuillet
Modified: 2006-08-25 18:39 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Description Stephane Loeuillet 2006-08-25 12:36:51 UTC 
2.15.92-0ubuntu1 (ubuntu edgy eft)

/usr/share/applications/gnome-power-preferences.desktop:X-GNOME-Bugzilla-Bugzilla=GNOME
/usr/share/applications/gnome-power-preferences.desktop:X-GNOME-Bugzilla-Product=gnome-power-manager
/usr/share/applications/gnome-power-preferences.desktop:X-GNOME-Bugzilla-Component=gnome-power-preferences
/usr/share/applications/gnome-power-preferences.desktop:X-GNOME-Bugzilla-Version=@VERSION@

Must be a problem in corresponding Makefile.am
Comment 1 Richard Hughes 2006-08-25 14:52:37 UTC 
Uhh. Thanks for the bug. I really don't want to have to make gnome-power-preferences.desktop.in.in for CVS. Any idea of how to fix this?

Thanks,

Richard.
Comment 2 Stephane Loeuillet 2006-08-25 15:17:42 UTC 
sorry but the only way I know is :

XXX.desktop.in.in => intltool => XXX.desktop.in (with translations) => Makefile.am/configure.in => XXX.desktop (translations + version string)

so I suppose you'll have to rename it in CVS and change generation rules.

Hopefully, it doesn't touch code so it's ok to change this after code freeze.

I'll try to fetch current code and make a patch if I manage to find some time before monday.
Comment 3 William Jon McCann 2006-08-25 15:21:08 UTC 
Or just remove the one line for this release and move to .in.in next cycle.  I don't even have the version line in the g-s one.
Comment 4 Stephane Loeuillet 2006-08-25 15:30:29 UTC 
X-GNOME-Bugzilla-Version is not mandatory for Bug-Buddy 2.16 support.

I suppose that having no version string at all is better than having "@VERSION@" for now.

Lets change to.in.in for 2.1[78] to make it properly as William suggested.

Another way is to hardcode '2.16.x' for now.

Just prepare to have lots of unversioned bug-buddy reports for current cycle.

keep this bug open, just change target for next cycle

X-GNOME-Bugzilla-Version=@VERSION@ => 
X-GNOME-Bugzilla-Version=2.16.x (for this cycle)
Comment 5 William Jon McCann 2006-08-25 15:36:07 UTC 
(In reply to comment #4)
> Just prepare to have lots of unversioned bug-buddy reports for current cycle.

Wow, that's optimism!  ;)

I don't think the preferences has crashed that much in the past...
Comment 6 Richard Hughes 2006-08-25 18:39:02 UTC 
Heh, thanks Jon :-)

I'l just hardcode the string 'X-GNOME-Bugzilla-Version=2.16.x' for now, it's a bit close to the release for my liking:

2006-08-25  Richard Hughes  <richard@hughsie.com>

	* data/gnome-power-manager.desktop.in:
	* data/gnome-power-preferences.desktop.in:
	Manually hardcode the version to 2.16.x to fix #352840.

I'll commit a similar patch to head (but use 2.17.x instead)