After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 352248 - Silence Camel exception warning at startup
Silence Camel exception warning at startup
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.8.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
evolution[codecleanup]
Depends on:
Blocks:
 
 
Reported: 2006-08-21 11:44 UTC by Matthew Barnes
Modified: 2013-09-13 00:52 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
Proposed patch (704 bytes, patch)
2006-08-21 11:45 UTC, Matthew Barnes
committed Details | Review

Description Matthew Barnes 2006-08-21 11:44:20 UTC
Every time I start Evolution I see this warning on the terminal:

    camel-WARNING **: camel_exception_get_id called with NULL parameter.

While the warning itself is harmless, it's interfering with my ability to debug Evolution using the G_DEBUG=fatal_warnings feature of GLib to trap warnings that I'm concerned about.  I'd like to get it fixed.

It's not clear to me whether Camel's API _requires_ exceptions to be provided by the caller.  Much of its logic seems to assume that an exception was provided and even relies on its presence to check for error conditions.  Yet it doesn't enforce non-NULL exception arguments.  I find that puzzling.

I would expect to see something like

    g_return_val_if_fail (ex != NULL, NULL);

guarding each of it's public functions that take a CamelException argument.  Or else define a local exception for detecting error conditions, and use something equivalent to g_propagate_error() as shown in the Description section of [1] to propagate the exception to the caller.

Anyway, instead of mucking around with Camel's error-reporting system, I silenced the warning by fixing the call from Evolution that's triggering it.

[1] http://developer.gnome.org/doc/API/2.0/glib/glib-Error-Reporting.html
Comment 1 Matthew Barnes 2006-08-21 11:45:48 UTC
Created attachment 71295 [details] [review]
Proposed patch
Comment 2 Srinivasa Ragavan 2006-08-21 15:45:37 UTC
Please commit :) with ChangeLog.
Comment 3 Matthew Barnes 2006-08-21 16:03:29 UTC
I'm afraid I don't have commit privilege yet.
I guess I need to request an account on gnome.org.
Comment 4 André Klapper 2006-08-21 16:29:34 UTC
committed to CVS HEAD on behalf of matthew:
http://cvs.gnome.org/viewcvs/evolution/mail/mail-send-recv.c?r1=1.109&r2=1.110

fix will be included in evolution 2.8.0.
<personally>thanks so much for fixing this!</personally>