GNOME Bugzilla – Bug 352248
Silence Camel exception warning at startup
Last modified: 2013-09-13 00:52:29 UTC
Every time I start Evolution I see this warning on the terminal: camel-WARNING **: camel_exception_get_id called with NULL parameter. While the warning itself is harmless, it's interfering with my ability to debug Evolution using the G_DEBUG=fatal_warnings feature of GLib to trap warnings that I'm concerned about. I'd like to get it fixed. It's not clear to me whether Camel's API _requires_ exceptions to be provided by the caller. Much of its logic seems to assume that an exception was provided and even relies on its presence to check for error conditions. Yet it doesn't enforce non-NULL exception arguments. I find that puzzling. I would expect to see something like g_return_val_if_fail (ex != NULL, NULL); guarding each of it's public functions that take a CamelException argument. Or else define a local exception for detecting error conditions, and use something equivalent to g_propagate_error() as shown in the Description section of [1] to propagate the exception to the caller. Anyway, instead of mucking around with Camel's error-reporting system, I silenced the warning by fixing the call from Evolution that's triggering it. [1] http://developer.gnome.org/doc/API/2.0/glib/glib-Error-Reporting.html
Created attachment 71295 [details] [review] Proposed patch
Please commit :) with ChangeLog.
I'm afraid I don't have commit privilege yet. I guess I need to request an account on gnome.org.
committed to CVS HEAD on behalf of matthew: http://cvs.gnome.org/viewcvs/evolution/mail/mail-send-recv.c?r1=1.109&r2=1.110 fix will be included in evolution 2.8.0. <personally>thanks so much for fixing this!</personally>