After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 352180 - [0.11] [API] remove_data_probe() should *not* take gulong
[0.11] [API] remove_data_probe() should *not* take gulong
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.10.4
Other All
: Normal enhancement
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 580459 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-08-20 20:25 UTC by Khaled Mohammed
Modified: 2012-06-27 15:53 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12



Description Khaled Mohammed 2006-08-20 20:25:49 UTC
Some of the add callback functions are return ulong handler_id, whereas the remove functions are accepting uint handler_id as a parameter. Here is an example:
gulong      gst_pad_add_data_probe          (GstPad *pad,
                                             GCallback handler,
                                             gpointer data);

void        gst_pad_remove_data_probe       (GstPad *pad,
                                             guint handler_id);

handler_id should either be int or long for both functions. 

Thank you.

Other information:
I have found at least 3 instances in GstPad class. Here is a link to the API: http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer/html/GstPad.html
Comment 1 Tim-Philipp Müller 2006-08-21 07:53:32 UTC
Known issue (I thought there was already a bug for it, but didn't find it), will be changed in 0.11 when we can break API/ABI again.

Comment 2 Wim Taymans 2009-04-27 15:24:16 UTC
*** Bug 580459 has been marked as a duplicate of this bug. ***
Comment 3 Tim-Philipp Müller 2011-10-27 12:24:32 UTC
This is not using signals any longer, so there's no need for the gulong stuff.

We want to get rid of "long" types in the API,l so should change it to int/uint.
Comment 4 Tim-Philipp Müller 2012-06-27 15:53:42 UTC
Well, still would have preferred to get rid of the ulongs in the API, but at least they're consistent now in git master, so this bug can be considered FIXED I think:

gulong  gst_pad_add_probe (GstPad *pad, ...)
void    gst_pad_remove_probe  (GstPad *pad, gulong id);