After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 351557 - [wavpackparse] resync in push mode if sync was lost
[wavpackparse] resync in push mode if sync was lost
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-08-15 21:55 UTC by Sebastian Dröge (slomo)
Modified: 2006-08-16 10:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wavpackparse-push-resync.diff (3.85 KB, patch)
2006-08-15 21:56 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2006-08-15 21:55:20 UTC 
Hi,
the attached patch resyncs wavpackparse in push mode if synchronization was lost. This works fine here if garbage is inserted between two wavpack blocks.

It also changes the property names of the encoder from foo_bar to foo-bar as required for moving the plugin to -good later.

Bye
Comment 1 Sebastian Dröge (slomo) 2006-08-15 21:56:02 UTC 
Created attachment 70991 [details] [review]
wavpackparse-push-resync.diff
Comment 2 Tim-Philipp Müller 2006-08-16 10:40:38 UTC 
Committed, thanks:

 2006-08-16  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Sebastian Dröge <slomo at circular-chaos.org>

        * ext/wavpack/gstwavpackenc.c: (gst_wavpack_enc_class_init):
        * ext/wavpack/gstwavpackparse.c:
        (gst_wavpack_parse_resync_adapter), (gst_wavpack_parse_chain):
          In push mode, re-sync to next wavpack header if sync is lost
          (#351557). Also use hyphens instead of underscores in
          GObject property names.