Created attachment 70954 [details] [review]
proposed patch

Committed, thanks ;)

At least for some other dialogs we pass the parent in so that when launched from the contact list, it's transient, and otherwise it's not. It's a bit strange that the dialog always ends up centered now.

I agree, but it is more strange IMO that it doesn't appear at all and when the user then clicks on the menu again, the items are still present when it looks like it silently cleared the list.

Other options are done from the contact list which has to be on the same screen.

Actually, I kind of agree with the positioning, I would rather it was close to the tray widget, but I am not sure we should really worry about it.

I meant that when started from the contact list, it should use that as transient, otherwise not. That makes it positioned properly.

I agree actually! Ahoy men, revert ALL patches immediately! Quickly, attension!! Move it move it!!

Reopening then.

The problem is that's the same GtkMenu for both. Maybe we should do something like that:

if (main window is visible and on the active virtual desktop)
  parent = main window
else
  parent = NULL

I guess to know about the current virtual desktop we should use libwnck ? I'll try to find how to do that.

We have some code to do that already, gossip_window_get_is_visible().

Fixed thanks.