After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 351431 - Greyed-out 'Browse Folders' should be singular or not shown
Greyed-out 'Browse Folders' should be singular or not shown
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: File and Folder Operations
2.21.x
Other All
: Normal normal
: ---
Assigned To: Paweł Paprota
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-08-15 11:33 UTC by Joachim Noreiko
Modified: 2008-08-21 10:27 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
351431-dont-show-browse-folders-when-selection-is-empty.patch (651 bytes, patch)
2008-04-26 17:31 UTC, Paweł Paprota 		committed Details | Review

Description Joachim Noreiko 2006-08-15 11:33:42 UTC 
In spatial mode, there is a menu command File->Browse Folder.

If more than one folder is selected, it says 'Browse Folders', which is ok.
If a file is selected, there are Open With commands in its place.
If nothing is selected, there is a greyed-out command 'Browse Folders'.

This is gramatically odd, because in English zero is a singular.
This is perhaps less than trivial because of how different languages treat zero.

However, since this menu command is already dynamic, I suggest the best solution is for it to be simply not shown when nothing is selected.
Comment 1 Cosimo Cecchi 2008-01-20 00:35:18 UTC 
Confirming with 2.21.5.
Comment 2 Paweł Paprota 2008-04-26 17:31:53 UTC 
Created attachment 109958 [details] [review]
351431-dont-show-browse-folders-when-selection-is-empty.patch
Comment 3 Christian Neumair 2008-04-27 18:09:53 UTC 
Paweł: Thank you for working on this. Please commit the patch to trunk and to the GNOME 2.22 branch.
Comment 4 Cosimo Cecchi 2008-08-21 10:27:32 UTC 
I committed the patch on your behalf so that it will make it into 2.24.
Closing as FIXED.

2008-08-21  Cosimo Cecchi  <cosimoc@gnome.org>

	* src/file-manager/fm-directory-view.c: (real_update_menus):
	Don't show "Browse Folders" in spatial mode if no folders are
	selected.
	Patch by Paweł Paprota (#351431).