Created attachment 70804 [details] [review]
Allows --enable-sqlite2 configure time option

./configure --enable-sqlite2, and viola! the user has forced sqlite2 over sqlite3.

Right idea, but it needs to fit in better with the existing sqlite checks.  

Consider this scenario: if you don't have sqlite2 installed but do have sqlite3 and pass in --enable-sqlite2, configure won't error out even though you don't have sqlite2.  Beagle will build fine but actually crash *at runtime* because don't have it.  (And we DllImport it, so there's not even a build-time error.)

I'd like to see this patch reworked so that if you pass in --enable-sqlite2, the checks for sqlite2 are strict and fatal and sqlite3 is not checked.  Moreover, I'd like to see an --enable-sqlite3 which does the exact same thing for sqlite3.

Created attachment 72001 [details] [review]
Update

Hey, this should do the trick, I can't uninstall the sqlite libs to check, so in a perfect world, could someone check that? But it does allow us to force either 2 or 3

Any thoughts?

This doesn't work because it does nothing if the check fails; it needs to error out.  It'd also be good to do those checks before the automatic detection and only do the automatic detection if the version isn't set.

Created attachment 73180 [details] [review]
Update Sqlite Version Selection

Ok, this should error out, and it checks for the commandline arguments first.

Looks good

Done and done.