GNOME Bugzilla – Bug 351100
add keyboard shortcut to delete bookmark/topics
Last modified: 2016-09-28 16:34:02 UTC
Hi, i'm using 2.14.3 on my ibook and it's not handy to delete a lot of bookmarks / folders because i don't have a DEL key, therefor i have to click on every folder to remove them. Please consider adding a shortcut (Ctrl+T like nautilus, or Ctrl+D like evolution) to delete bookmarks and folders. Thanks.
Sounds good, but ctrl+t and ctrl+d are in use. Maybe HIG says something about this?
Maybe 'Delete' should be added to the Edit menu, so anyone can assign their own shortcut using the method GTK provides.
Actually, it's there. File > Delete. The GTK+ feature of changing the accelerators is not well known however... Should this have a default shortcut?. Nautilus uses Ctrl+T.
Created attachment 76368 [details] [review] Implements control+T as default delete shortcut After thinking a while, I thought that having the same shortcut that Nautilus has would be a good idea. I came to think that maybe new tab can be confused with this, but the bme is in a totally different context and I can't see someone trying to open a new bme tab. Also there's already a menu item for opening in tabs that is shift+control+O. Anyway, the patch indicates where to do the change if control+T is proved to not be the best shortcut.
Hmm... in nautilus Ctrl-T moves to trash, from where you can undo, but we have no undo...
Diego: can you also add a Delete item to the Edit menu (cf comment #2)?
Related: bug 164071
Reinout: You say that Delete should be in Edit instead of File?
You're right! It's in the File menu. I wouldn't have thought of looking for it there. :-/ The same thing for Rename. I would expect these in the Edit menu. Opinions?
Delete should probably be in Edit, yes.
So, what are we going to do, we are close if not after the freeze?.
Then it's a minimal change to data/ui/epiphany-bookmark-editor-ui.xml file. The file data/ui/epiphany-history-window-ui.xml should be changed too for consistency. The default shortcut patch can still be applied separately. A possible shortcut could be control+shift+D (since control+D bookmarks). But it's too long... maybe control+K or control+J?
Moving to 2.20 target due to feature and UI freeze for 2.18.
Diego, ping?
We just need to agree on what will be the shortcut, it's a one liner.
We already have a shortcut, the Del key. Is there a reason why we cannot simply display that?
The problem was that some keyboards doesn't have the Del key.
In that case I suggest to follow the nautilus shortcut. The fact that we don't have undo is a separate bug.
setting to NEW.
Created attachment 89434 [details] [review] Changes the Delete item position and also gives it a default shortcut I intend to commit this.
Committed to trunk as revision 7076. 2007-06-05 Diego Escalante Urrelo <diegoe@gnome.org> * src/ephy-history-window.c * src/bookmarks/ephy-bookmarks-editor.c * data/ui/epiphany-history-window-ui.xml * data/ui/epiphany-bookmark-editor-ui.xml: Assign control+T as default delete shortcut. Also move the Delete item to Edit menu. Bug #351100. Btw, does separators in History window need a name?: <separator name="EditSep2"/>
*** Bug 529081 has been marked as a duplicate of this bug. ***
I'd like to reopen this bug to propose the change of "Ctrl+T" to something else. Nautilus already gave up on it ( see bug 156915 ) as it is too easy to delete files, and the shortcut in normally associated with opening tabs, not deleting. This is even worse for epiphany as the action can't be undone.
Hm, maybe still need a better solution for this, but a keyboard shortcut is probably not the right way, given the new design. Also, with a shortcut we'd have to use a confirmation dialog to avoid data loss, which would be unfortunate.