After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 350878 - GtkIconTheme is not screen safe
GtkIconTheme is not screen safe
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-08-11 12:27 UTC by Carlos Garcia Campos
Modified: 2006-08-13 11:20 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16

Attachments
Patch (10.47 KB, patch)
2006-08-11 12:34 UTC, Carlos Garcia Campos 		committed Details | Review

Description Carlos Garcia Campos 2006-08-11 12:27:55 UTC 
It's the same problem as #350145. In sidebar attachments page we should use gtk_icon_theme_get_for_screen() instead of get_default().
Comment 1 Carlos Garcia Campos 2006-08-11 12:34:07 UTC 
Created attachment 70707 [details] [review]
Patch

Here is a patch that fixes it. In addition icon_theme is only used when the document has attachments and the "changed" signal is disconnected when the sidebar page is destroyed. I think it could fix other bugs related to attachments and icon_theme.
Comment 2 Carlos Garcia Campos 2006-08-13 11:20:21 UTC 
Fixed in head, I hope it fixes #340956 #348884 and #351093 too.