GNOME Bugzilla – Bug 350809
Exif MakerNotes are not decoded (even when supported by libexif)
Last modified: 2007-06-23 11:10:02 UTC
When viewing an image with EXIF data, no makernotes are shown. The section "Maker Note" is empty and section "Other" says "MakerNote: xxxx bytes unknown data". However, the libexif library has support to decode some (but not all) makernotes. Supported makernote tags can be viewed with the commandline exif tool: exif --show-mnote filename.jpg I think it is worth adding this data, because for instance my camera only stores the ISO value in the makernote. And that is certainly valuable data for a photographer.
Created attachment 70677 [details] [review] Simple patch to show MakerNotes in the EXIF viewer
From a quick look I noticed a little problem with the patch when switching images. Instead of replacing the old maker tags it simply appends the new ones to the list.
Created attachment 78589 [details] [review] Patch to show makernotes in the EXIF viewer (v2) I didn't noticed that before. It is caused by the fact that I did not read/update the hash table for the makernotes. In this patch, I added a extra hash table for the makernotes, to prevent overwriting normal tags (I'm not sure this will ever happen). During my testing I noticed another problem with the hashtable approach. If you first view an image which contains tag X, and switch to another image without this tag, this tag remains present in the viewer, but the value is empty. I'm not sure if that is the intended behaviour.
I just committed your patch (Thanks!) to trunk as a newer libexif with improved Makernote support has finally been released. (rev. 3827) 2007-06-23 Felix Riemann <> * src/eog-exif-details.c: (eog_exif_details_dispose), (eog_exif_details_init), (exif_entry_cb), (eog_exif_details_reset): Display EXIF MakerNotes supported by libexif. Patch by Jef Driesen. Fixes bug #350809. * configure.ac: Bump libexif requirement to 0.6.14. The issue with the ghost tags should hopefully been fixed by a commit I made a few days ago. This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.
*** Bug 387055 has been marked as a duplicate of this bug. ***