After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 350655 - [oggdemux] should process seeking queries
[oggdemux] should process seeking queries
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.10
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-08-09 22:11 UTC by Jonathan Matthew
Modified: 2006-08-10 09:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (932 bytes, patch)
2006-08-09 22:12 UTC, Jonathan Matthew
reviewed Details | Review

Description Jonathan Matthew 2006-08-09 22:11:00 UTC
When activated in push mode, oggdemux disables seeking (->seekable = FALSE).  It doesn't process seeking queries, though, so if the source is seekable, an application can get the idea that it will be able to seek, but oggdemux won't allow it to.
Comment 1 Jonathan Matthew 2006-08-09 22:12:31 UTC
Created attachment 70593 [details] [review]
patch

This just modifies the seekable flag in the seeking query results returned from upstream.
Comment 2 Tim-Philipp Müller 2006-08-10 09:01:43 UTC
Implemented this slightly differently. oggdemux can only seek in TIME format, so it should answer the query in TIME format as well. Currently the assumption in oggdemux is that we're either fully seekable (pullrange-based) or not seekable at all (chain-based), but one day upstream may provide more sophisticated seek ranges (in BYTE format), then we might want to pass the query upstream and then convert the byte ranges received into specific TIME ranges or something like that. For the time being this should hopefully do:

 2006-08-10  Tim-Philipp Müller  <tim at centricular dot net>

       * ext/ogg/gstoggdemux.c: (gst_ogg_pad_src_query):
         Implement SEEKING query in its most basic form, so that we can
         at least check if we're seekable or not (#350655).