GNOME Bugzilla – Bug 349557
Clicking favicon doesn't select URL
Last modified: 2006-09-13 21:15:26 UTC
Hadn't used epiphany for a while, and it's looking good, but one thing that's really biting me is my Safari/Firefox habit of clicking the favicon in the location bar to select the URL text... which doesn't work in epiphany. Any chance of implementing this, or is there a reason for it?
Created attachment 70640 [details] [review] Clicking favicon selects URL The use case is not clear but discussion is open. The patch does the job, so let's the UI gurus to give a gonogo.
It makes sense for me. When you drag the favicon you expect to move the url so it would be consistent to have the url selected.
I agree it's difficult to put forward a convincing use-case; it's just one of those things that when you know about it, it's usually quicker than double-clicking somewhere in the address bar. I guess I also do it because I'm used to Safari's double-click behaviour, which is only to select one element of the URL, not the whole thing (which I also find more useful than Epiphany/Firefox's selection model, but that's a different bug report I guess). Perhaps a better way to look at it is to consider it analogous to anywhere else that we represent an object or document with text plus an icon, e.g. the list view in nautilus. For selection purposes, the icon is just an extension of the text label, so when you select either of them, both are selected.
Ok, let's try this for 2.17. + if (event->type == GDK_BUTTON_PRESS && event->button == 1 /* left */) Add a check for (event->state & gtk_accelerator_get_default_mod_mask ()) == 0 here when committing it (HEAD only).
Commit done on CVS HEAD. 2006-09-13 Jean-François Rameau <jframeau@cvs.gnome.org> * lib/widgets/ephy-location-entry.c: (ephy_location_entry_construct_contents), (icon_button_press_event_cb): Clicking favicon in the location bar selects URL. Fix bug #349557.