After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 349271 - Help kill libegg
Help kill libegg
Status: RESOLVED OBSOLETE
Product: goobox
Classification: Other
Component: player
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Goobox Maintainers
Goobox Maintainers
Depends on:
Blocks: 349256
 
 
Reported: 2006-07-30 10:57 UTC by Vincent Untz
Modified: 2010-06-09 14:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
replace EggTrayIcon (10.05 KB, patch)
2006-10-03 13:03 UTC, Felix Riemann
none Details | Review
replace EggTrayIcon with backwards compatibility (8.67 KB, patch)
2006-10-03 15:54 UTC, Felix Riemann
none Details | Review

Description Vincent Untz 2006-07-30 10:57:49 UTC
+++ This bug was initially created as a clone of Bug #349256 +++

Please help kill libegg. Your module contains some egg code that is now deprecated thanks to new features, most probably the new GTK+ 2.10 features like:

 + GtkRecent* (deprecating EggRecent)
 + GtkStatusIcon (deprecating EggTrayIcon and EggStatusIcon)
 + GtkCellRendererAccel (deprecating EggCellRendererKeys)
 + GtkAccelGroup now has features to deprecate EggAccelerator (see bug 85780)

Also, egg-screen-exec stuff has been deprecated: see http://cvs.gnome.org/viewcvs/*checkout*/libegg/libegg/screen-exec/README

Also, EggIconList has become GtkIconView in GTK+ 2.6.
Comment 1 Felix Riemann 2006-10-03 13:03:15 UTC
Created attachment 73942 [details] [review]
replace EggTrayIcon

This patch replaces the EggTrayIcon with a GtkStatusIcon.
It also adds the libnotify-0.3 patch from bug #332462 since libnotify-0.4.1 is the first version supporting GtkStatusIcon objects. It has a little signalling bug though (http://trac.galago-project.org/ticket/81), but a fixed version is not out yet (0.4.3).
Comment 2 Felix Riemann 2006-10-03 15:54:40 UTC
Created attachment 73955 [details] [review]
replace EggTrayIcon with backwards compatibility

This is an enhanced version of the last patch. It makes it possible that goobox can still be used with gtk+ <2.10 (where the old EggTrayIcon is used).
Comment 3 André Klapper 2009-05-18 07:18:06 UTC
can this patch get a review?
Comment 4 Paolo Bacchilega 2009-05-18 07:50:23 UTC
the patch doesn't apply to current version, it needs to be updated.
Comment 5 Paolo Bacchilega 2010-06-09 14:50:20 UTC
version 2.1.1 fixes this issue.