After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 349258 - Help kill libegg
Help kill libegg
Status: RESOLVED FIXED
Product: gwget
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: David Sedeño Fernández
David Sedeño Fernández
Depends on:
Blocks: 349256
 
 
Reported: 2006-07-30 10:33 UTC by Vincent Untz
Modified: 2006-12-11 19:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to get rid of libegg (6.82 KB, patch)
2006-10-15 17:47 UTC, Arjan Timmerman 		committed Details | Review

Description Vincent Untz 2006-07-30 10:33:25 UTC 
+++ This bug was initially created as a clone of Bug #349256 +++

Please help kill libegg. Your module contains some egg code that is now deprecated thanks to new features, most probably the new GTK+ 2.10 features like:

 + GtkRecent* (deprecating EggRecent)
 + GtkStatusIcon (deprecating EggTrayIcon and EggStatusIcon)
 + GtkCellRendererAccel (deprecating EggCellRendererKeys)
 + GtkAccelGroup now has features to deprecate EggAccelerator (see bug 85780)

Also, egg-screen-exec stuff has been deprecated: see http://cvs.gnome.org/viewcvs/*checkout*/libegg/libegg/screen-exec/README

Also, EggIconList has become GtkIconView in GTK+ 2.6.
Comment 1 Arjan Timmerman 2006-10-15 17:47:40 UTC 
Created attachment 74761 [details] [review]
patch to get rid of libegg
Comment 2 Arjan Timmerman 2006-10-15 17:48:53 UTC 
there is one problem with this patch, GtkStatusIcon doesn't support drag and drop. 
It probably is better to have it as an applet anyway ;) 
The notification area is gettig too busy anyway.
Comment 3 David Sedeño Fernández 2006-10-17 21:35:55 UTC 
Hi Arjan,

Thanks for the patch.

With the patch aplied there are some warnings in the build. I think that the patch have missed the types in include/*.h.  

Maybe do you have forgot to include this modifications in the patch?

You are right about the drag'n'drop. Maybe the correct way will be a applet, and use the notificacion area only when a download is completed or there are an error.

Cheers.
Comment 4 Arjan Timmerman 2006-10-18 06:41:13 UTC 
hmmm, i will take a look at the warning tonight. I never noticed them.

I will see what i can do tonight :)
Comment 5 David Sedeño Fernández 2006-12-11 19:33:52 UTC 
I have committed a patch based on yours to cvs.

Thanks a lot!