After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 348807 - New rectangle selection tool does not allow resizing along the vertical.
New rectangle selection tool does not allow resizing along the vertical.
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Tools
git master
Other All
: Normal normal
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
: 350698 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-07-26 16:30 UTC by Karl Günter Wünsch
Modified: 2006-08-10 07:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Preliminiary patch to calculate vertical size on the base of horizontal resizing and desired aspect ratio. (1.60 KB, patch)
2006-07-26 22:59 UTC, Karl Günter Wünsch
none Details | Review
Updated patch, corrects the positioning and resizing of the corners as well. (3.34 KB, patch)
2006-07-28 20:15 UTC, Karl Günter Wünsch
committed Details | Review

Description Karl Günter Wünsch 2006-07-26 16:30:36 UTC
Please describe the problem:
When the aspect ratio is fixed in the new rectangle selection tool then trying to resize the selected area along the vertical is having little effect unless you move the mouse in very fast movements.

Steps to reproduce:
1. Select a rectangle
2. fix the Aspect to whatever you like (I tried 0.6666, 1.0 and 1.5)
3. try to resize the area by grabbing the right hand delimiter line of the area.


Actual results:
The resize seems to be quite reluctant, mouse cursor and delimiter line get asynchronous quite quickly.

Expected results:
I'd expect the same behaviour as if I tried to resize by using the bottom delimiter line which tracks the mouse movement, thereby resizing the horizontal size as well as dictated by the aspect ratio.

Does this happen every time?
Yes.

Other information:
Comment 1 Karl Günter Wünsch 2006-07-26 22:59:34 UTC
Created attachment 69698 [details] [review]
Preliminiary patch to calculate vertical size on the base of horizontal resizing and desired aspect ratio.

It's preliminary as the whole code seems to always factor in both x and y resizing even when only one direction is in fact being altered.
Comment 2 Karl Günter Wünsch 2006-07-28 20:15:53 UTC
Created attachment 69847 [details] [review]
Updated patch, corrects the positioning and resizing of the corners as well.
Comment 3 Karine Delvare 2006-07-30 19:44:41 UTC
Simple fix for the horizontal movement problem. Thanks to Karl Günter Wünsch for working and discussing on this issue, and we still need to improve the corners' behaviour (old rectangle tool had a better behaviour, where the mouse cursor always stayed on one border).

2006-07-30  Karine Delvare  <edhel@gimp.org>

	* app/tools/gimprectangletool.c: check zero division in the right
	place. Fixes bug #348807.
Comment 4 Michael Schumacher 2006-08-05 08:30:03 UTC
Setting milestone accordingly. Has the attached patch been committed?
Comment 5 Karl Günter Wünsch 2006-08-05 08:34:44 UTC
The attached patch has been committed but since has been superseded by the fixes for Bug #349337...
Comment 6 Karine Delvare 2006-08-10 07:00:34 UTC
*** Bug 350698 has been marked as a duplicate of this bug. ***