GNOME Bugzilla – Bug 348633
Help killl libegg :-)
Last modified: 2006-07-30 12:40:22 UTC
eggaccelerators is not needed anymore with GTK+ 2.10. See bug #85780. Here's a patch to help kill libegg proliferation. The egg files should also be removed. And I guess you'd also need to check for GTK+ 2.10 in configure.in... A quick test makes me think it works okay. You should verify, though.
Created attachment 69572 [details] [review] patch
someone should check on gconf key forward and backward compat (i.e. old settings should work with new metacity, new settings should work with old metacity)
I've tested this and it works fine. The differences between the parts of the libraries we use are: 1. egg_accelerator_parse_virtual, gtk_accelerator_parse These use almost identical code. The only difference is that EAPV returns a gboolean whereas GAP returns void; the patch accounts for this difference correctly. 2. egg_virtual_accelerator_name, gtk_accelerator_name Identical. 3. The constants. Some differ, e.g. EGG_VIRTUAL_HYPER_MASK is 2**26 instead of 2**27. This is not a problem since they're being used symbolically. Therefore the patch should be back and forward compatible.
sounds good - libegg_users -= 1
I have committed this. Actually, now I realise I should have asked whether vuntz was supposed to commit it, or whether I should have asked whether he wanted to. Sorry.
Thomas: don't worry about that :-) And thanks for the reactiveness. This rocks! Let's close the bug since we don't need it anymore.