After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 348582 - Random by Album
Random by Album
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Playback
unspecified
Other Linux
: Normal enhancement
: 2.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-07-24 22:58 UTC by Carlos Moffat
Modified: 2009-06-17 11:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Adds shuffle by album and shuffle by artist (20.84 KB, patch)
2007-03-11 10:52 UTC, Scott Peterson
none Details | Review
shuffle by album icon (974 bytes, image/png)
2007-03-11 10:53 UTC, Scott Peterson
  Details
THIS is the shuffle by artist. (838 bytes, image/png)
2007-03-11 10:55 UTC, Scott Peterson
  Details
Slightly revised patch (20.92 KB, patch)
2007-03-11 11:09 UTC, Scott Peterson
none Details | Review
patch v3 (21.21 KB, patch)
2007-03-12 09:04 UTC, Scott Peterson
none Details | Review
patch v4 (21.05 KB, patch)
2007-03-12 11:30 UTC, Scott Peterson
none Details | Review
Patch to apply agains 1.4.3 (10.47 KB, patch)
2009-06-03 04:06 UTC, Alexander Kojevnikov
none Details | Review

Description Carlos Moffat 2006-07-24 22:58:20 UTC
It'd be nice to have the feature of playing whole albums randomly.
Comment 1 Dominik Meister 2006-07-27 09:55:00 UTC
You could just use the search box for filtering the library to the album you'd like to listen to. Or you could create a (smart) playlist.
Comment 2 Carlos Moffat 2006-08-04 15:31:38 UTC
Well, I'm not sure how a playlist would solve the problem. I would like banshee to play randomly from my library but keeping the albums together. Selecting them manually with the search function is *a* solution, but not a very good one, as I'd have to select a new album every time. And I could order things by album, but then the 'random' bit is lost.

Thanks for your feedback.
Comment 3 Sébastien Bertrand 2006-10-22 22:44:40 UTC
+1
I think it could be a very cool feature...

But be careful : Amarok can do it but it sort first by artist and then by album, so it doesn't work with compilation (an album with various artist ;) !)
Comment 4 Josiah Ritchie - flickerfly 2007-01-18 21:00:22 UTC
How could this be added to the interface cleanly?

To be clear, you want to hear a whole album first to last track and then have another album selected randomly to play first to last track?
Comment 5 Carlos Moffat 2007-01-18 21:57:33 UTC
Well, 'repeat' has already three choices: 'none', 'all', and 'single'. What about doing the same for shuffle, where you would have 'none', 'song', 'album'?

Thanks.
Comment 6 Scott Peterson 2007-03-11 10:52:03 UTC
Created attachment 84373 [details] [review]
Adds shuffle by album and shuffle by artist

This patch adds shuffle by album and shuffle by artist. I combined icon-artist.png & icon-album.png with the shuffle icon. They're pretty small, so perhaps more salient icons are needed.
Comment 7 Scott Peterson 2007-03-11 10:53:09 UTC
Created attachment 84374 [details]
shuffle by album icon

This goes in /banshee/data/images/
Comment 8 Scott Peterson 2007-03-11 10:55:18 UTC
Created attachment 84375 [details]
THIS is the shuffle by artist.

My apologies, the other image is the shuffle by album icon. This is the shuffle by artist.

This also goes in /banshee/data/images/
Comment 9 Scott Peterson 2007-03-11 11:09:20 UTC
Created attachment 84376 [details] [review]
Slightly revised patch

Revised the patch to handler "Unknown Artist".
Comment 10 Scott Peterson 2007-03-12 09:04:30 UTC
Created attachment 84417 [details] [review]
patch v3

This patch fixes an issue with continuous playback. It seems certain classes must be declared in a certain order due to reflection.
Comment 11 Scott Peterson 2007-03-12 11:30:39 UTC
Created attachment 84423 [details] [review]
patch v4

It turns out I hadn't fixed the problem as well as I'd thought. This should take care of everything.
Comment 12 Josiah Ritchie - flickerfly 2007-08-23 03:27:44 UTC
Please specify the latest version of banshee you have been able to test this against or let us know that this is no longer a problem. Thank you for helping us keep track of your bug.
Comment 13 Bertrand Lorentz 2008-08-21 19:27:04 UTC
The UI part seems to be in banshee since 1.0, but the actual "Random by Album" isn't implemented yet.

So the patch needs a lot of work to apply to trunk.
Comment 14 Carlos Moffat 2009-05-06 13:18:28 UTC
Hi,

I wonder if there are any news on this bug. The UI has had a "Random by Album" option grayed out for a while now, which suggest this feature is coming soon, but the history of this bug suggest otherwise.

Thanks.
Comment 15 Gabriel Burt 2009-06-03 01:58:47 UTC
Implemented in git master!
Comment 16 Carlos Moffat 2009-06-03 02:05:33 UTC
Hi Gabriel,

That is fantastic news. I don't suppose there's a patch I can apply to 1.4.3 to try it?

Thanks again!
Comment 17 Alexander Kojevnikov 2009-06-03 02:46:46 UTC
It doesn't quite work for me. Steps to reproduce:

0. Select "Shuffle by album"
1. Press "Next"

This works. The first track of a random album starts playing.

2. Press "Next"

This also works, playback jumps to the next track of the same album.

3. Press "Next" a few more times until all album's tracks are skipped.

This jumps to the last song in the album, after this the "Next" button does nothing at all. When the song finishes, playback just stops.

4. Double click a random song in the library. Playback starts.
5. Press "Next"

Nothing happens, the song continue playing. When it finishes playback stops.

I'm re-opening the bug.
Comment 18 Alexander Kojevnikov 2009-06-03 04:00:05 UTC
Committed the fix.
Comment 19 Alexander Kojevnikov 2009-06-03 04:06:42 UTC
Created attachment 135861 [details] [review]
Patch to apply agains 1.4.3

(In reply to comment #16)
> That is fantastic news. I don't suppose there's a patch I can apply to 1.4.3 to
> try it?

This is a cherry-picked patch to apply to 1.4.3
Comment 20 Carlos Moffat 2009-06-03 11:21:32 UTC
Alexander,

Great, thanks. It's working great!

Comment 21 Daniel Sousa 2009-06-17 10:53:27 UTC
I need intructions on how to install the patch. I've followed these steps:
1. Download Banshee 1.4.3 source-code from banshee website and extract it
2. Put the patch in the same folder as Banshee
3. In the console I cd to Banshee directory and run the command: patch banshee.patch

But the console sits there and I don't know what's going on.
Comment 22 Daniel Sousa 2009-06-17 11:17:21 UTC
I applied the patch manually, but now I can't install form source (I always use synaptic). I'm getting the error:

>checking for GLIB - version >= 2.0.0... no
>*** Could not run GLIB test program, checking why...
>*** The test program failed to compile or link. See the file config.log for the
>*** exact error that occured. This usually means GLIB is incorrectly installed.
>checking for GTK... configure: error: Package requirements (gtk+-2.0 >= 2.8) were >not met:
>
>No package 'gtk+-2.0' found
>
>Consider adjusting the PKG_CONFIG_PATH environment variable if you
>installed software in a non-standard prefix.
>
>Alternatively, you may set the environment variables GTK_CFLAGS
>and GTK_LIBS to avoid the need to call pkg-config.
>See the pkg-config man page for more details.

Please help me
Comment 23 Alexander Kojevnikov 2009-06-17 11:20:44 UTC
(In reply to comment #21)
> I need intructions on how to install the patch. I've followed these steps:
> 1. Download Banshee 1.4.3 source-code from banshee website and extract it
> 2. Put the patch in the same folder as Banshee
> 3. In the console I cd to Banshee directory and run the command: patch
> banshee.patch
> 
> But the console sits there and I don't know what's going on.
> 

To apply the patch run this:

$ git apply /path/to.patch

Then follow the build instructions from:

http://banshee-project.org/contribute/write-code/
http://banshee-project.org/download/development/

If you have problems stop by #banshee on irc.gnome.org
Comment 24 Daniel Sousa 2009-06-17 11:44:18 UTC
Thanks for your help, but everything is already running. I applied the patch manually and run the command:
>apt-get build-dep banshee
to install all dependencies.

Main point: Banshee is the best player xD

Thanks for your help and for the patch.