After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 348399 - Tango and icon naming update for stock_fullscreen
Tango and icon naming update for stock_fullscreen
Status: RESOLVED FIXED
Product: adwaita-icon-theme
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Jakub Steiner
Jakub Steiner
Depends on:
Blocks: 348350
 
 
Reported: 2006-07-23 10:24 UTC by Luca Ferretti
Modified: 2006-07-25 14:02 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Description Luca Ferretti 2006-07-23 10:24:11 UTC 
Please describe the problem:
Currently we have "stock_fullscreen" and "stock_leave-fullscreen" icons

Issues are:
  * bot aren't using tango style for appearance
  * stock_fullscreen should be deprecated. Use instead "view-fullscreen"

Plase note that:
  * GTK+ provides named icons "gtk-leave-fullscreen" GTK_STOCK_LEAVE_FULLSCREEN)
    and "gtk-fullscreen" (GTK_STOCK_FULLSCREEN). Most apps are using them
  * icon-naming-utils don't support neither stock_fullscreen, nor gtk-fullscreen
    (I'll open a bug+patch)
  * Icon Naming Standard don't provide any leave fullscreen icon

This means that:
  1. Someone should draw "view-fullscreen"
  2. Someone should fix icon-naming-utils to use it
  3. When we have new icon and fixed icon-naming-utils we can put the icon in g-i-t and remove stock_fullscreen.

Unfortunately this can't fix the leave fullscreen icon :-(

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Luca Ferretti 2006-07-23 10:42:21 UTC 
Relevant bugs for Icon Naming Standard:
 
* https://bugs.freedesktop.org/show_bug.cgi?id=7601
  icon-naming-utils: missing support for fullscreen icons in GTK+ and g-i-t

* https://bugs.freedesktop.org/show_bug.cgi?id=4820
  Tango specification is missing view-fullscreen-leave
Comment 2 Rodney Dawes 2006-07-24 19:55:00 UTC 
THe two fdo bugs are taken care of in terms of getting the link working. However, the appropriate icon name is "view-restore" rather than "view-fullscreen-leave".
Comment 3 Luca Ferretti 2006-07-24 22:51:00 UTC 
Rodney, I suspect you forgot the `cvs add` for renamed icons:

Making all in actions
make[2]: Entering directory `/home/luca/cvs/gnome2/gnome-icon-theme/16x16/actions'
make[2]: *** No rule to make target `view-fullscreen.png', needed by `all-am'.  Stop.
make[2]: Leaving directory `/home/luca/cvs/gnome2/gnome-icon-theme/16x16/actions'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/luca/cvs/gnome2/gnome-icon-theme/16x16'
make: *** [all-recursive] Error 1
Comment 4 Rodney Dawes 2006-07-24 23:40:57 UTC 
Already fixed Luca.
Comment 5 Jakub Steiner 2006-07-25 14:02:55 UTC 
I've added the tangoified view-fullscreen and view-restore icons to git HEAD.