After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 348347 - The Eye tool in the Layer Dialog does not work
The Eye tool in the Layer Dialog does not work
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: General
2.2.x
Other All
: High normal
: 2.2
Assigned To: GIMP Bugs
GIMP Bugs
: 430226 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-07-22 17:35 UTC by Joshua Rothfarb
Modified: 2008-01-15 13:10 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Joshua Rothfarb 2006-07-22 17:35:28 UTC
Please describe the problem:
The Eye Does not do anything (Does not hide the layer)

Steps to reproduce:
1. Start the program
2. create 2 layers
3. pressing the eye on one of them


Actual results:
Nothing. No way to hide a layer (apart from changing transparency to 0

Expected results:
The eye should dissapear and the layer should become hidden

Does this happen every time?
yes

Other information:
I tried it on 3 differnt computers with linux (ubuntu 6.06) and one computer with windows xp. In all cases I am using hebrew
Comment 1 Michael Natterer 2006-07-24 11:41:20 UTC
Never seen such a thing. Does it work when not using Hebrew but English
instead? It might be the fault of not getting the button press coordinates
correctly calculated with right-to-left rendering.
Comment 2 Michael Schumacher 2006-07-24 13:30:37 UTC
At least the problem can be easily reproduced with 'export LANG=he'.
This has come up previously, either as a bug report (maybe reassigned to GTK+?) or on a mailing list.
Comment 3 Michael Natterer 2006-07-26 09:42:54 UTC
Found the reason:

Before GTK+ 2.7.0, gtk_tree_view_get_path_at_pos() was fixed to
take RTL into account, but GIMP is still working around its
previous buggyness.

2.2 and HEAD need different fixes, since HEAD depends on 2.8,
will commit fixes later today.
Comment 4 Michael Natterer 2006-07-26 09:47:17 UTC
Fixed in HEAD:

2006-07-26  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpcontainertreeview.c
	(gimp_container_tree_view_button_press): removed code that was
	special-casing RTL since gtk_tree_view_get_path_at_pos() takes
	this correctly into account now. Fixes bug #348347.
Comment 5 Michael Natterer 2006-07-26 10:04:09 UTC
Fixed in 2.2 too:

2006-07-26  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpcontainertreeview.c
	(gimp_container_tree_view_button_press): added runtime version
	check and adjust the coords for RTL only for GTK+ < 2.7.0 because
	gtk_tree_view_get_path_at_pos() does the right thing by itself
	after this version. Fixes bug #348347.
Comment 6 Michael Schumacher 2007-01-30 00:24:32 UTC
Reopening. The problem does occur in GIMP 2.2 again - Linux and Windows, GTK+ 2.10.9 and 2.8.20.
Comment 7 Tor Lillqvist 2007-01-30 00:35:42 UTC
Isn't the use of gtk_check_version() backwards? gtk_check_version(2,7,0) returns NULL (i.e. FALSE) if GTK+ is 2.7.0 or newer. Yeah, this is a bit backwards and easy to remember wrong.
Comment 8 Sven Neumann 2007-01-30 10:03:59 UTC
2007-01-30  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpcontainertreeview.c
	(gimp_container_tree_view_button_press): corrected the GTK+
	version check. Closes bug #348347 again.
Comment 9 Sven Neumann 2007-04-16 10:52:42 UTC
*** Bug 430226 has been marked as a duplicate of this bug. ***