After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 347988 - HEAD fails to build (changes in EContactPhoto)
HEAD fails to build (changes in EContactPhoto)
Status: RESOLVED FIXED
Product: deskbar-applet
Classification: Deprecated
Component: general
Git master
Other Linux
: Normal normal
: ---
Assigned To: Deskbar Applet Maintainer(s)
Deskbar Applet Maintainer(s)
: 348560 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-07-19 08:37 UTC by Frederic Peters
Modified: 2006-07-26 16:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
restore inline contact photo support (814 bytes, patch)
2006-07-19 08:40 UTC, Frederic Peters 		committed Details | Review

Description Frederic Peters 2006-07-19 08:37:54 UTC 
#313533 got fixed and this caused the EContactPhoto struct to change, so
it supports both inline photos and URI.

deskbar-applet needs to be updated.
Comment 1 Frederic Peters 2006-07-19 08:40:48 UTC 
Created attachment 69161 [details] [review]
restore inline contact photo support

Patch to get 1) deskbar-applet to build again and 2) keeping support for
inline photos.

This doesn't address photos referenced by URI (I'm sorry but I don't have time
to work on this part for the moment).
Comment 2 Sebastien Bacher 2006-07-25 21:19:39 UTC 
*** Bug 348560 has been marked as a duplicate of this bug. ***
Comment 3 Jose M. daLuz 2006-07-26 04:07:26 UTC 
This bug still exists in 2.15.90. The patch applies cleanly to that version and the build works.
Comment 4 Ross Burton 2006-07-26 07:54:18 UTC 
As the author of the EContactPhoto change, I approve of this patch.  [insert big red stamp here]
Comment 5 Elijah Newren 2006-07-26 16:05:43 UTC 
As per the call for help on d-d-l from Nigel, I committed this patch and will shortly roll a release with it.  Thanks for the patch Frederic!