After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 347985 - fix RhythmDB shutdown
fix RhythmDB shutdown
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-07-19 07:25 UTC by James "Doc" Livingston
Modified: 2006-07-19 11:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (8.29 KB, patch)
2006-07-19 07:27 UTC, James "Doc" Livingston 		none Details | Review

Description James "Doc" Livingston 2006-07-19 07:25:26 UTC 
The recent leak fixes have unhidden a few issues with RhythmDB's shutdown. The most important of which is that various asynchronous operations aren't cancelled when it happens, which can cause the callbacks to be run after the db is finalised.
Comment 1 James "Doc" Livingston 2006-07-19 07:27:42 UTC 
Created attachment 69158 [details] [review]
patch

This make it remove all outstanding idle/timeout sources, and cancels all gnomevfs operations.

With this valgrinding tests/test-rhythmdb (with CK_FORK=no) only appears to leak the RhythmDBEntry structures (plus some GTK and GnomeVFS stuff which we can't really help).
Comment 2 Jonathan Matthew 2006-07-19 10:39:02 UTC 
Looks OK to me.
Comment 3 James "Doc" Livingston 2006-07-19 11:18:16 UTC 
Committed to cvs.