After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 347970 - fedora suspend/hibernate patch for gnome-panel
fedora suspend/hibernate patch for gnome-panel
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: menu
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-07-18 22:46 UTC by Ray Strode [halfline]
Modified: 2006-07-24 14:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
slightly cleaned up version of gpm integration patch (27.82 KB, patch)
2006-07-18 22:48 UTC, Ray Strode [halfline]
committed Details | Review

Description Ray Strode [halfline] 2006-07-18 22:46:38 UTC
Starting with FC5, we added a patch in fedora to integrate gnome-power-manager with the panel.

The patch could use some cleanup:
- it does synchronous calls (maybe not a big deal since we're about to suspend anyway)
- its error reporting is a little funky

but otherwise, it works okay.

Anyway, the patch has been languishing in fedora cvs way too long.  We should have upstreamed it months ago.
Comment 1 Ray Strode [halfline] 2006-07-18 22:48:00 UTC
Created attachment 69147 [details] [review]
slightly cleaned up version of gpm integration patch
Comment 2 Vincent Untz 2006-07-24 14:55:02 UTC
Thanks Ray!
I committed it after a big reindent :-)
I also didn't commit the part about the suspend action button. I don't know if this is what we want... I put buttons in the shut down dialog instead. Not really better, though...