GNOME Bugzilla – Bug 347443
[wavpack] port parser/decoder to official API and random cleanup
Last modified: 2006-07-18 14:12:21 UTC
Hi, attached is a patch that ports the parser/decoder to the official API of libwavpack, implements correction file support in the decoder (although not tested yet) and does some random cleanup. Also missing licenses were added to the beginning of files. There are still some other things I want to do with the wavpack parser/decoder but I'll wait for it until this is committed as it depends on this. Bye
Created attachment 68882 [details] [review] gstwavpack.diff the diff. I forgot that it also adds clipping to the decoder.
Patch will be replaced by a new one after some discussion on IRC.
Created attachment 68917 [details] [review] gstwavpack-2.diff the updated patch. additionally fixes a bug that happened when seeking to the end of a file.
Created attachment 68918 [details] [review] gstwavpack-3.diff oops... the clipping code wasn't by tim but by bilboed...
Committed with a whole bunch of changes: 2006-07-18 Tim-Philipp Müller <tim at centricular dot net> Patch by: Sebastian Dröge <slomo at circular-chaos.org> * configure.ac: Check for wavpack version and define WAVPACK_OLD_API if necessary. * ext/wavpack/Makefile.am: * ext/wavpack/gstwavpackcommon.c: (gst_wavpack_read_header), (gst_wavpack_read_metadata): * ext/wavpack/gstwavpackcommon.h: * ext/wavpack/gstwavpackdec.c: (gst_wavpack_dec_base_init), (gst_wavpack_dec_class_init), (gst_wavpack_dec_init), (gst_wavpack_dec_finalize), (gst_wavpack_dec_format_samples), (gst_wavpack_dec_clip_outgoing_buffer), (gst_wavpack_dec_chain), (gst_wavpack_dec_sink_event), (gst_wavpack_dec_change_state), (gst_wavpack_dec_request_new_pad), (gst_wavpack_dec_plugin_init): * ext/wavpack/gstwavpackdec.h: * ext/wavpack/gstwavpackenc.c: (gst_wavpack_enc_class_init), (gst_wavpack_enc_init), (gst_wavpack_enc_finalize), (gst_wavpack_enc_set_wp_config): * ext/wavpack/gstwavpackparse.c: (gst_wavpack_parse_base_init), (gst_wavpack_parse_finalize), (gst_wavpack_parse_class_init), (gst_wavpack_parse_index_get_entry_from_sample), (gst_wavpack_parse_scan_to_find_sample), (gst_wavpack_parse_handle_seek_event), (gst_wavpack_parse_create_src_pad): * ext/wavpack/gstwavpackstreamreader.c: * ext/wavpack/gstwavpackstreamreader.h: Port to new/official wavpack API, don't use API that was exported in wavpack header files and in the lib but meant to be private, at least not for recent wavpack versions; misc. 'cleanups' (#347443). Next time it would be nice if you could do separate patches for library API updates, additional stuff like clipping and cleanups/whitespace fixes/randomly moving functions around - it's a lot more work reviewing mega-patches like this if everything is mixed together :)