After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 347372 - [patch] nautilus location bar cannot extract samba multibyte URI
[patch] nautilus location bar cannot extract samba multibyte URI
Status: RESOLVED WONTFIX
Product: eel
Classification: Deprecated
Component: general
2.14.x
Other All
: Normal major
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-07-13 07:58 UTC by Takao Fujiwara
Modified: 2006-08-09 11:13 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
Problem URI (34.80 KB, image/png)
2006-07-13 07:59 UTC, Takao Fujiwara
  Details
patch for eel-2.14.1/eel/eel-vfs-extensions.c (790 bytes, patch)
2006-07-13 08:00 UTC, Takao Fujiwara
none Details | Review

Description Takao Fujiwara 2006-07-13 07:58:14 UTC
Please describe the problem:
In eel_format_uri_for_display_internal(), multibyte path names are extracted by gnome_vfs_get_local_path_from_uri() in the local path. But if users uses samba URI,  the multibyte chars cannot be extracted by gnome_vfs_get_local_path_from_uri() because it's not a local path. At the result, nautilus location bar cannot show samba multibyte URIs.

Steps to reproduce:
1. Configure a samba filesystem on UNIX.
2. Launch Nautilus Window on ja_JP.UTF-8.
3. Click [Windows Network] icon and open the samba filesystem 'smb:///$hostname'.
4. Open the folders which have the UTF-8 encoding filename.



Actual results:
The multibyte chars are not shown on the Nautilus location bar.


Expected results:
'smb:///$hostname/$UTF-8_filename' is shown.

Does this happen every time?
always

Other information:
I'm attaching the patch & problem snapshot.
Comment 1 Takao Fujiwara 2006-07-13 07:59:02 UTC
Created attachment 68845 [details]
Problem URI
Comment 2 Takao Fujiwara 2006-07-13 08:00:20 UTC
Created attachment 68846 [details] [review]
patch for eel-2.14.1/eel/eel-vfs-extensions.c

I'm attaching the patch.
Comment 3 Baptiste Mille-Mathias 2006-07-13 08:05:50 UTC
Hello Takao,

To make the patch rewieved quick I advice you to post your patch the nautilus list (nautilus-list@gnome.org), I think you need to suscribe to be able to post a mail.

bye

Comment 4 Alexander Larsson 2006-08-08 12:55:32 UTC
That patch looks wrong. We're not supposed to unescape the string there. And this is not really related to gnome_vfs_get_local_path_from_uri(), since that is only used for file:// uris.

The main problem is that URIs are really not utf8. If you want to have non-ascii in them you need to escape them. This is unfortunate. However, it is required, since if we tried to do anything automagic with the uri when displayed we'd have trouble with roundtrips in the entry. If the user pressed enter in the entry we'd get back a different uri than what we put in there.
Comment 5 Takao Fujiwara 2006-08-09 11:13:46 UTC
Are there any possible ways to show multibyte chars for smb: protocol only? The problem is users expect MS Windows compatibilities when they access the filesystem via Nautilus. The wide aged people will use smb: protocol.
The problem is Nautilus address bar only.