After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 347357 - DECtalk driver should convert strings to "code page 850"
DECtalk driver should convert strings to "code page 850"
Status: RESOLVED FIXED
Product: gnome-speech
Classification: Deprecated
Component: drivers
0.4.x
Other Solaris
: Normal critical
: ---
Assigned To: Willie Walker
GNOME Speech Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2006-07-12 23:43 UTC by Rich Burridge
Modified: 2006-07-13 17:31 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
StarOffice test document. (17.58 KB, application/vnd.oasis.opendocument.text)
2006-07-12 23:43 UTC, Rich Burridge
  Details
Orca debug output generated when traversing StarOffice document. (77.39 KB, text/plain)
2006-07-12 23:44 UTC, Rich Burridge
  Details
Patch to convert text to ISO8859-1 before sending to DECtalk engine (2.83 KB, patch)
2006-07-13 17:31 UTC, Willie Walker
committed Details | Review

Description Rich Burridge 2006-07-12 23:43:14 UTC
If you try to traverse over a line in the attached StarOffice
document that has a non-breaking space in it ("\302\240"), then
this generates COMM_FAILURES and multiple tracebacks (see attached
output).
Comment 1 Rich Burridge 2006-07-12 23:43:57 UTC
Created attachment 68839 [details]
StarOffice test document.
Comment 2 Rich Burridge 2006-07-12 23:44:46 UTC
Created attachment 68840 [details]
Orca debug output generated when traversing StarOffice document.
Comment 3 Willie Walker 2006-07-13 11:54:10 UTC
This may be related to Tomas Cerha's comment that we're doing all our string management in Orca in UTF-8 when we probably should be using unicode strings and then translating to the character set expected by the things we use externally (e.g., gnome-speech and BrlTTY).

Alternatively, what might also need to happen is that some sort of conversion should be done in the gnome-speech driver for DECtalk.  It looks like the driver is passing UTF-8 strings to the DECtalk engine, which may not be what it is expecting.  I'll contact the DECtalk folks to see what's legal.
Comment 4 Willie Walker 2006-07-13 14:50:11 UTC
After discussion with the DECtalk engineer at Fonix, we've determined that DECtalk expects strings from "code page 850".  I'm reassigning this to gnome-speech, whose DECtalk driver should do the appropriate string conversion from UTF-8 to cp850.

I've also checked to make sure we're not losing the other portion of this bug (handling the COMM_FAILURE for speech). It is already logged as bug 319531 (http://bugzilla.gnome.org/show_bug.cgi?id=319531).
Comment 5 Willie Walker 2006-07-13 17:31:29 UTC
Created attachment 68880 [details] [review]
Patch to convert text to ISO8859-1 before sending to DECtalk engine

After testing and more discussion with Fonix, we're now more certain that the encoding expected by DECtalk is ISO8859-1 and not code page 850.  This patch provides the conversion to ISO8859-1.
Comment 6 Willie Walker 2006-07-13 17:31:53 UTC
Fixed in the development version. The fix will be available in the next major release. Thank you for your bug report.