After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 347168 - Nautilus should use 32x32 icons for 75% view mode
Nautilus should use 32x32 icons for 75% view mode
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Views: Icon View
2.15.x
Other All
: Normal minor
: 2.16.x
Assigned To: Christian Neumair
Nautilus Maintainers
Depends on:
Blocks: 472263
 
 
Reported: 2006-07-11 02:08 UTC by Max Powers
Modified: 2007-09-04 17:36 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
This is what 25% looks like in nautilus now (24.40 KB, image/png)
2007-01-22 00:47 UTC, Andreas Nilsson
  Details
This is what 25% would look like if it used 16x16 (25.27 KB, image/png)
2007-01-22 00:49 UTC, Andreas Nilsson
  Details
Well reasoned, attaching proposed patch (704 bytes, patch)
2007-03-16 14:49 UTC, Christian Neumair
none Details | Review

Description Max Powers 2006-07-11 02:08:30 UTC
Nautilus currently uses 36x36 icons for 75% view mode under "view as icons," however 36x36 is not a natural dimension for an icon. 32x32 is a common (and recently added to the Tango desktop project) dimension for icons. Nautilus should draw from the 32x32 icon repositories from an icon set. This would make icons under the 75% view as icon mode "pixel perfect."

Other information:
Comment 1 Christian Neumair 2006-07-29 06:58:33 UTC
This is what we currently use:

/* Nominal icon sizes for each Nautilus zoom level.
 * This scheme assumes that icons are designed to
 * fit in a square space, though each image needn't
 * be square. Since individual icons can be stretched,
 * each icon is not constrained to this nominal size.
 */
#define NAUTILUS_ICON_SIZE_SMALLEST     12
#define NAUTILUS_ICON_SIZE_SMALLER      24
#define NAUTILUS_ICON_SIZE_SMALL        36
#define NAUTILUS_ICON_SIZE_STANDARD     48
#define NAUTILUS_ICON_SIZE_LARGE        72
#define NAUTILUS_ICON_SIZE_LARGER       96
#define NAUTILUS_ICON_SIZE_LARGEST     192

Which of them don't fit into the tango sizing scheme? Is there an (xdg?) paper describing the suggested icon sizes?
Comment 2 Max Powers 2006-07-29 07:48:59 UTC
#define NAUTILUS_ICON_SIZE_SMALLEST     12
#define NAUTILUS_ICON_SIZE_SMALLER      24
#define NAUTILUS_ICON_SIZE_SMALL        36
#define NAUTILUS_ICON_SIZE_STANDARD     48
#define NAUTILUS_ICON_SIZE_LARGE        72
#define NAUTILUS_ICON_SIZE_LARGER       96

http://tango.freedesktop.org/Tango_Icon_Theme_Guidelines (Look under Sizes)

So , it should be:

#define NAUTILUS_ICON_SIZE_SMALLEST     16
#define NAUTILUS_ICON_SIZE_SMALLER      22
#define NAUTILUS_ICON_SIZE_SMALL        32
#define NAUTILUS_ICON_SIZE_STANDARD     48
...

If you look at their online library: http://tango.freedesktop.org/Tango_Icon_Gallery you will see the 3 sizes in use.

That is the best I can do for documentation, but hope it's enough. Thanks for your attention.

Comment 3 Rodney Dawes 2006-07-29 10:35:15 UTC
The general idea is that icon sizes should be divisible by 8. The 22x22 size is a fluke so that we can improve compatibility with KDE, but this size actually makes things look much better on the panel as well. Lokheed's suggested sizes are probably the ones we should be using. The 24 vs. 22 is debatable, as we can easily automate the process of generating most all of the 24x24 versions of icons from the 22x22 anyway, as we do in the Tango Icon Theme at "build" time.
Comment 4 Andreas Nilsson 2007-01-22 00:47:50 UTC
Created attachment 80845 [details]
This is what 25% looks like in nautilus now

quite blurry, hard to see what they are.
Comment 5 Andreas Nilsson 2007-01-22 00:49:07 UTC
Created attachment 80846 [details]
This is what 25% would look like if it used 16x16

Sharp and clear!
No icon set that I know of uses anything below 16x16.
Comment 6 Andreas Nilsson 2007-01-22 00:55:34 UTC
Seems #327709 is about the same issue.
Comment 7 Lapo Calamandrei 2007-03-16 10:12:58 UTC
Any progress on thit one? As you can see from Andreas screenshoots it improove the look and feel quite a lot.
Comment 8 Christian Neumair 2007-03-16 14:49:46 UTC
Created attachment 84718 [details] [review]
Well reasoned, attaching proposed patch

This one will change 12 -> 16 and 36 -> 32.
Comment 9 Alexander Larsson 2007-03-19 15:10:21 UTC
Sounds good to me.
Commited.
Comment 10 Fryderyk Dziarmagowski 2007-09-04 05:21:02 UTC
Changing icon size values unchanged since 7 years without giving old users a chance to have the old setting after upgrade does no sounds like a good idea.
IMO it's a regression (filled as #472263)
Comment 11 Fryderyk Dziarmagowski 2007-09-04 05:45:49 UTC
Almost forgot: 48*0.75=36 != 32
Comment 12 Andreas Nilsson 2007-09-04 09:18:29 UTC
Um, "the old setting" was that your icons was blurry instead of sharp and we're just talking about a couple of pixels here. Are you sure this is a issue?
Comment 13 Fryderyk Dziarmagowski 2007-09-04 15:28:18 UTC
Yes, they are not sharp as 32px ones. But they have a perfect 36px size, present on my GNOME desktop since few years. 
Comment 14 Rodney Dawes 2007-09-04 16:10:58 UTC
I don't understand how they can be perfect, when nobody actually provides icons in that size.
Comment 15 Fryderyk Dziarmagowski 2007-09-04 16:39:44 UTC
I never saw icons with such size, but that's not the point. After upgrade, I want to have same desktop as before (probably I'm not alone). That's all. If sombody prefers better look/size can always use new provided setting. I know, that's not a big issue for new GNOME users, but I'm the old one and I want keep my prefered settings. 
Comment 16 Lapo Calamandrei 2007-09-04 17:36:11 UTC
Fryderyk, this patch correct a long standing nautilus issue, we never had nice icons at that zoom level, I don't think anybody will notice the difference in spacing since we are really talking about a bunch of pixels.
Having all blurred icons is obviously bogus to my eyes, to me it's sounds like you want a bug back.