After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 346980 - libxklavier causes gnome-settings-daemon to crash when no X keyboard options are used
libxklavier causes gnome-settings-daemon to crash when no X keyboard options ...
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] settings-daemon
2.15.x
Other All
: Normal critical
: ---
Assigned To: Sergey V. Udaltsov
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-07-08 14:38 UTC by Ben Gamari
Modified: 2006-07-29 17:56 UTC
See Also:
GNOME target: 2.16.x
GNOME version: 2.15/2.16

Attachments
Add sanity checking code into libxklavier (399 bytes, patch)
2006-07-08 14:39 UTC, Ben Gamari 		none Details | Review

Description Ben Gamari 2006-07-08 14:38:17 UTC 
Steps to reproduce:
1. Start gnome-settings-daemon


Stack trace:
(gdb) bt

+ Trace 69246

  • #0 IA__g_logv
    at gmessages.c line 502
  • #1 IA__g_log
    at gmessages.c line 517
  • #2 IA__g_return_if_fail_warning
    at gmessages.c line 532
  • #3 IA__g_strjoinv
    at gstrfuncs.c line 2456
  • #4 xkl_strings_concat_comma_separated
    at xklavier_config.c line 278
  • #5 xkl_config_rec_merge_options
    at xklavier_config.c line 272
  • #6 xkl_config_rec_set_to_root_window_property
    at xklavier_props.c line 389
  • #7 xkl_engine_backup_names_prop
    at xklavier_props.c line 206
  • #8 gnome_settings_keyboard_xkb_init
    at gnome-settings-keyboard-xkb.c line 390
  • #9 gnome_settings_daemon_new
    at gnome-settings-daemon.c line 345
  • #10 main
    at factory.c line 66 


Other information:
I'm not sure whether XklConfigRec.options is ever supposed to be NULL, but if so the problem probably lies in xkl_straings_concat_comma_separated which doesn't check for a non-null array. I have attached a patch to correct this.
Comment 1 Ben Gamari 2006-07-08 14:39:31 UTC 
Created attachment 68621 [details] [review]
Add sanity checking code into libxklavier

The attached patch fixes the problem for me
Comment 2 Rodrigo Moya 2006-07-10 10:06:38 UTC 
Sergey, does it look ok to you?
Comment 3 Sebastien Bacher 2006-07-23 20:37:52 UTC 
Sergey, could you comment on that patch? If that's a libxklavier issue that should be closed as NOTGNOME and it would be nice to have a new libxklavier tarball fixing it before GNOME 2.16.0
Comment 4 Jeremy Messenger 2006-07-23 21:36:59 UTC 
I have a same issue on FreeBSD 6.1-STABLE when trying to use GNOME 2.15.4 in VNC. This patch (68621) has solved this issue, so I agree with Sebastien for it would be nice to have a new libxklavier tarball with the fix before GNOME 2.16.x.
Comment 5 Sergey V. Udaltsov 2006-07-29 17:53:36 UTC 
OK, it seems to be reasonable. I'll apply this patch.