After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 346844 - Access keys for "Edit Anyway" and "Don't Edit" don't work
Access keys for "Edit Anyway" and "Don't Edit" don't work
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: general
2.14.x
Other Linux
: Normal minor
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2006-07-07 07:33 UTC by Matthew Paul Thomas (mpt)
Modified: 2009-08-31 09:08 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
accel_keys patch (1.07 KB, patch)
2009-08-30 13:54 UTC, Ignacio Casal Quinteiro (nacho)
needs-work Details | Review
accel_keys patch v2 (1.34 KB, patch)
2009-08-30 20:02 UTC, Ignacio Casal Quinteiro (nacho)
none Details | Review

Description Matthew Paul Thomas (mpt) 2006-07-07 07:33:16 UTC
When I open the same file twice, the yellow banner along the top contains two buttons, "Edit Anyway" and "Don't Edit". "Edit Anyway" claims to have the access key "E", but Alt+E opens the Edit menu instead. And "Don't Edit" claims to have the access key "D", but Alt+D opens the Documents menu instead.
Comment 1 Fernando Munoz 2007-06-08 06:57:50 UTC
I don't think this bug applies anymore since current behavior (2.18.1) is to switch to the tab with that document instead of asking to reopen the file.
Comment 2 Andy Owen 2009-02-07 02:34:55 UTC
That only seems to happen if the window with it open is on the current virtual desktop. (gedit 2.24.2).
Comment 3 Ignacio Casal Quinteiro (nacho) 2009-08-30 13:54:31 UTC
Created attachment 142068 [details] [review]
accel_keys patch

As usual I remember to fix this kind of bugs when we are on string freeze, so let's leave this here for next cycle.
Comment 4 Claude Paroz 2009-08-30 18:40:51 UTC
nacho, your patch still contains an error:
_("_Edit An_yway"),

Should we infer from your patch that the access key of these strings should be different from other main menu access keys? If this is the case, you should still add a translator comment explaining this. E.g.: /* Translators: the access key chosen for this string should be different from other main menu access keys (Open, Edit, View...) */
Comment 5 Ignacio Casal Quinteiro (nacho) 2009-08-30 20:02:29 UTC
Created attachment 142083 [details] [review]
accel_keys patch v2

Fixed and added the comments.
Comment 6 Ignacio Casal Quinteiro (nacho) 2009-08-31 09:08:30 UTC
Fixed on master using 'w' instead of 'y' as hig says we should try to avoid using 'y'