GNOME Bugzilla – Bug 346723
gstneonhttpsrc fails for URL
Last modified: 2006-07-07 11:44:05 UTC
gstneonhttpsrc fails for the following URL: http://streaming.tagesschau.de/bb/redirect.lsc?rewrite=http://www.tagesschau.de/styles/container/video/style_video_real/0,1319,OID5683676_RESreal256,00.smi&content=content&media=rm The reason is that it currently escapes the path with the result that the server cannot find the file. The server expects an unescaped path.
Created attachment 68445 [details] [review] Patch to fix problem This patch fixes the problem with the following URL: http://streaming.tagesschau.de/bb/redirect.lsc?rewrite=http://www.tagesschau.de/styles/container/video/style_video_real/0,1319,OID5683676_RESreal256,00.smi&content=content&media=rm While at it: * (gst_neonhttp_src_unlock) Removed. start/stop will do everything needed * (request_dispatch) Removed code that was never called. * (gst_neonhttp_src_create) Use gst_pad_alloc_buffer. Don't send EOS - parent class does that for us. * (set_uri): Do not escape path.
The set_uri change looks reasonable and correct. What's the reason for the rest of the changes, though? Even if these are correct, they're unrelated to the bug report, and should be done separately. I don't know the neon API well enough to review these unrelated changes.
Patch by: Lutz Mueller <lutz at topfrose dot de> * ext/neon/gstneonhttpsrc.c: (gst_neonhttp_src_class_init), (gst_neonhttp_src_init), (gst_neonhttp_src_finalize), (request_dispatch), (gst_neonhttp_src_create), (gst_neonhttp_src_start), (gst_neonhttp_src_get_size), (gst_neonhttp_src_stop), (set_proxy), (set_uri), (gst_neonhttp_src_set_property), (gst_neonhttp_src_get_property), (gst_neonhttp_src_uri_set_uri), (size_header_handler): * ext/neon/gstneonhttpsrc.h: Remove unlock function. start/stop will do everything needed Removed code that was never called. Use gst_pad_alloc_buffer. Don't send EOS - parent class does that for us. Do not escape path. Fixes #346723. Additional code cleanups.