After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 346723 - gstneonhttpsrc fails for URL
gstneonhttpsrc fails for URL
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.4
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-07-06 06:08 UTC by Lutz Mueller
Modified: 2006-07-07 11:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to fix problem (6.06 KB, patch)
2006-07-06 06:14 UTC, Lutz Mueller
committed Details | Review

Description Lutz Mueller 2006-07-06 06:08:53 UTC
gstneonhttpsrc fails for the following URL: 

http://streaming.tagesschau.de/bb/redirect.lsc?rewrite=http://www.tagesschau.de/styles/container/video/style_video_real/0,1319,OID5683676_RESreal256,00.smi&content=content&media=rm

The reason is that it currently escapes the path with the result that the server cannot find the file. The server expects an unescaped path.
Comment 1 Lutz Mueller 2006-07-06 06:14:31 UTC
Created attachment 68445 [details] [review]
Patch to fix problem

This patch fixes the problem with the following URL: http://streaming.tagesschau.de/bb/redirect.lsc?rewrite=http://www.tagesschau.de/styles/container/video/style_video_real/0,1319,OID5683676_RESreal256,00.smi&content=content&media=rm

While at it:
 * (gst_neonhttp_src_unlock) Removed. start/stop will do everything needed
 * (request_dispatch) Removed code that was never called.
 * (gst_neonhttp_src_create) Use gst_pad_alloc_buffer. Don't send EOS - parent
   class does that for us.
 * (set_uri): Do not escape path.
Comment 2 Michael Smith 2006-07-07 09:04:58 UTC
The set_uri change looks reasonable and correct. 

What's the reason for the rest of the changes, though? Even if these are correct, they're unrelated to the bug report, and should be done separately. I don't know the neon API well enough to review these unrelated changes.
Comment 3 Wim Taymans 2006-07-07 11:44:05 UTC
        Patch by: Lutz Mueller <lutz at topfrose dot de>

        * ext/neon/gstneonhttpsrc.c: (gst_neonhttp_src_class_init),
        (gst_neonhttp_src_init), (gst_neonhttp_src_finalize),
        (request_dispatch), (gst_neonhttp_src_create),
        (gst_neonhttp_src_start), (gst_neonhttp_src_get_size),
        (gst_neonhttp_src_stop), (set_proxy), (set_uri),
        (gst_neonhttp_src_set_property), (gst_neonhttp_src_get_property),
        (gst_neonhttp_src_uri_set_uri), (size_header_handler):
        * ext/neon/gstneonhttpsrc.h:
        Remove unlock function. start/stop will do everything needed
        Removed code that was never called.
        Use gst_pad_alloc_buffer. Don't send EOS - parent class does that for us.
        Do not escape path. Fixes #346723.
        Additional code cleanups.