GNOME Bugzilla – Bug 346501
build failure in burn-sharp/glue.c; ncb 2.15.x API change
Last modified: 2006-07-20 01:17:13 UTC
nautilus-cd-burner API has changed in 2.15.x, breaking banshee burn-sharp. i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/include/libnautilus-burn -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -ggdb -O1 -O2 -O3 -pipe -march=athlon-xp -mmmx -msse -m3dnow -MT glue.lo -MD -MP -MF .deps/glue.Tpo -c glue.c -fPIC -DPIC -o .libs/glue.o glue.c: In function 'nautilus_burn_glue_drive_get_id': glue.c:26: error: 'NautilusBurnDrive' has no member named 'cdrecord_id' glue.c: In function 'nautilus_burn_glue_drive_get_type': glue.c:32: error: 'NautilusBurnDrive' has no member named 'type' glue.c: In function 'nautilus_burn_glue_drive_get_display_name': glue.c:38: error: 'NautilusBurnDrive' has no member named 'display_name' glue.c: In function 'nautilus_burn_glue_drive_get_max_read_speed': glue.c:44: error: 'NautilusBurnDrive' has no member named 'max_speed_read' glue.c: In function 'nautilus_burn_glue_drive_get_max_write_speed': glue.c:50: error: 'NautilusBurnDrive' has no member named 'max_speed_write' glue.c: In function 'nautilus_burn_glue_drive_get_device': glue.c:56: error: 'NautilusBurnDrive' has no member named 'device' make[1]: *** [glue.lo] Error 1
Created attachment 68328 [details] [review] burn-sharp-ncb-2.15.3.patch Patch.
One of the things on my list has been to get a 2.15+ GNOME setup on a box somewhere to fix libnautilus-burn support, so thank you for this patch. However, burn-sharp also needs to work with 2.12, so the current glue still needs to be available if running 2.12. There was some 2.12/2.14 detection code in configure.ac which should be expanded into some sort of preprocessor macro to conditionally decide which method to use for getting properties in the glue.
Created attachment 68353 [details] [review] burn-sharp-ncb-2.15.3.patch Uh, like this?
Created attachment 68354 [details] [review] burn-sharp-ncb-2.15.3.patch Oh... need to include config.h. Oops.
Could it be a dupe of #338507 ?
No, this is an actual breakage.
This will never work. 2.14 doesn't have the functions you add and 2.15 doesn't have soname 3 but has soname 4. 2.14 is still compatible with 2.12 (although you get deprecation warnings) but not compatible with 2.15.
There needs to be another version detection for 2.15, and the define needs to be based on that. The conditional in the glue should only target 2.15. Also in configure.ac, (like the detection for 2.13) when 2.15 is detected, the soname needs to be set to 4. Ed: don't feel obligated to make these changes, it's on my list to do anyway (most of lnb-sharp needs a rehaul). However, an updated patch will surely be accepted :)
Created attachment 68955 [details] [review] burn-sharp-ncb-2.15.3.patch Gotcha. This better?
That works for me. Thanks!
*** Bug 348068 has been marked as a duplicate of this bug. ***
Thanks Ed!