GNOME Bugzilla – Bug 346192
[PATCH] Pad blocking on events
Last modified: 2006-07-03 10:31:46 UTC
Pads should properly block on events (see design document gstreamer/docs/design/part-block.txt). This implements the proper pad behaviour for the design document.
*** Bug 346193 has been marked as a duplicate of this bug. ***
Created attachment 68160 [details] [review] Patch for blocking on events
Created attachment 68215 [details] [review] same thing with more comments Same patch but with more comments. The code in the event function still seems awkward (the switch checking for the event type and then the additional checking in the _IS_BLOCKED section) Can you also attach the fix you had to do in the testsuite?
Created attachment 68237 [details] [review] Patch with comments and test fix Updated with gstevent test fix.
Created attachment 68238 [details] [review] Updated with smaller code Updated version. I combined the switch for flushing events with the pad block handling.
2006-07-03 Edward Hervey <edward@fluendo.com> * gst/gstpad.c: (handle_pad_block), (gst_pad_push_event): Implement pad blocking on events according to part-block.txt. More comments on behaviour. * tests/check/gst/gstevent.c: (test_event): Send event to peer pad of blocked pad (else it will block).