After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 345666 - The icons of file, directory and device at GtkFileChooser
The icons of file, directory and device at GtkFileChooser
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
2.9.x
Other All
: Normal minor
: ---
Assigned To: gtk-bugs
Federico Mena Quintero
Depends on:
Blocks:
 
 
Reported: 2006-06-22 15:33 UTC by Kazuki Iwamoto
Modified: 2011-02-04 16:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for gtkfilesystem.c (2.36 KB, patch)
2006-06-22 15:36 UTC, Kazuki Iwamoto 		none Details | Review
This screenshot is before the patch. (61.75 KB, image/jpeg)
2006-06-22 15:39 UTC, Kazuki Iwamoto 		  Details
This screenshot is after the patch. (47.14 KB, image/jpeg)
2006-06-22 15:40 UTC, Kazuki Iwamoto 		  Details

Description Kazuki Iwamoto 2006-06-22 15:33:18 UTC 
If GNOME theme is not installed, GtkFileChooser may not display appropriate icons.
I think that if an appropriate icon can not be gotten, stock-item had better be used.
And an warning message is displayed when an icon can not be loaded.
I think that I had better use 'gtk_icon_theme_has_icon'.

Other information:
Comment 1 Kazuki Iwamoto 2006-06-22 15:36:13 UTC 
Created attachment 67849 [details] [review]
patch for gtkfilesystem.c
Comment 2 Kazuki Iwamoto 2006-06-22 15:39:12 UTC 
Created attachment 67850 [details]
This screenshot is before the patch.
Comment 3 Kazuki Iwamoto 2006-06-22 15:40:15 UTC 
Created attachment 67851 [details]
This screenshot is after the patch.
Comment 4 Matthias Clasen 2006-08-15 17:28:49 UTC 
2006-08-15  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkfilesystem.c (gtk_file_info_render_icon) 
	(gtk_file_system_volume_render_icon): Do better fallbacks
	if the icon theme does not have icons.  (#345666,
	Kazuki Iwamoto)