GNOME Bugzilla – Bug 345560
stamp-it target broken for po directories not directly located under $(top_srcdir)
Last modified: 2006-12-09 04:04:57 UTC
Hi, Daniel Leidert reported in Debian bug http://bugs.debian.org/374836: """ In /usr/share/intltool/Makefile.in.in the stamp-it target is defined with the following prerequisites: stamp-it: Makefile.in.in ../config.status POTFILES.in But po directories not directly located under $(top_srcdir) miss the ../config.status prerequisite. So the target should be fixed to be: stamp-it: Makefile.in.in $(top_builddir)/config.status POTFILES.in (this fix can also be found in gettext's Makefile.in.in). """ Bye,
I don't see how the suggested fix could work. top_builddir is defined to .. in Makefile.in.in, so you still end up with ../config.status as the dependency...
Created attachment 67792 [details] [review] proposed patch to solve this issue The attached patch solves the reported issue and makes at least 'make clean/distclean' work. But I can see more issues, e.g. the defined subdir variable, which must be read from Makevars! Please note, that this bug makes IT_PO_SUBDIR(path/to/po) useless.
Created attachment 67793 [details] [review] proposed patch to solve this issue The attached patch solves the reported issue and makes at least 'make clean/distclean' work. But I can see more issues, e.g. the defined subdir variable, which must be read from Makevars! Please note, that this bug makes IT_PO_SUBDIR(path/to/po) useless.
(In reply to comment #1) > I don't see how the suggested fix could work. top_builddir is defined to .. in > Makefile.in.in, so you still end up with ../config.status as the dependency... True. I did not check the whole situation carefully. But the patch I created contains a few more changes, that work. But without fixing the usage of subdir, the 'make' target will still fail. The following comes from a 'make distcheck' run. [..] make[4]: Entering directory `/home/dl/packages/workspace/bluefish-project/bluefish-unstable-1.1/_build/src/plugin_about/po' INTLTOOL_EXTRACT=../../../intltool-extract srcdir=../../../../src/plugin_about/po ../../../intltool-update --gettext-package bluefish-unstable --pot /usr/bin/xgettext: Öffnen der Datei »../../../../src/plugin_about/po/../src/plugin_about/about.c« zum Lesen fehlgeschlagen: Datei oder Verzeichnis nicht gefunden (file or directory not found) ERROR: xgettext failed to generate PO template file. Please consult error message above if there is any. make[4]: *** [bluefish-unstable.pot] Fehler 1 The next problem here: GETTEXT_PACKAGE cannot be changed. But in a program-source, where you have more than one po-subdir it will almost always be the case, that GETTEXT_PACKAGE is not the same for all subdirs. Regards, Daniel
Fixed in CVS. Thanks for the patch.