After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 345554 - Support video/divx embeds
Support video/divx embeds
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Browser plugin (obsolete)
1.5.x
Other Linux
: Normal normal
: ---
Assigned To: totem-browser-maint
totem-browser-maint
Depends on:
Blocks:
 
 
Reported: 2006-06-21 15:11 UTC by Bastien Nocera
Modified: 2006-09-07 22:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
totem-mully-plugin.patch (13.91 KB, patch)
2006-09-05 14:45 UTC, Bastien Nocera
accepted-commit_after_freeze Details | Review

Description Bastien Nocera 2006-06-21 15:11:11 UTC
+++ This bug was initially created as a clone of Bug #333074 +++

File doesn't play in Mozilla:
http://community.divx.com/movies/details.php?id=228

because the server-side detection code is slightly broken.
Mailed webmaster@divx.com about it.
Comment 1 Bastien Nocera 2006-09-05 14:27:27 UTC
The detection has been "fixed". Now it only relies on the plugin name[1].

To implement the Javascript interface, this SDK should contain the docs:
http://download.divx.com/player/DivXWebPlayer_WebmasterSDK.zip

And another example video is at:
http://stage6.divx.com/members/66592/videos/1006708

[1]: http://stage6.divx.com/javascripts/content.js?1157157616
Comment 2 Bastien Nocera 2006-09-05 14:45:36 UTC
Created attachment 72252 [details] [review]
totem-mully-plugin.patch

Only things to fix are the UUID of the Javascript component, and the Javascript interface itself.
Comment 3 Christian Persch 2006-09-05 15:21:12 UTC
+[scriptable, uuid(aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa)]

Use 'uuidgen' here (apt-get install libuuid1)

+/* 67DABFBF-D0AB-41fa-9C46-CC0F21721616 */
+static const nsCID kClassID = 
+  { 0x67DABFBF, 0xD0AB, 0x41fa,
+    { 0x9C, 0x46, 0xCC, 0x0F, 0x21, 0x72, 0x16, 0x16 } };

The others use lowercase hex here... btw you can generate this with the script at 
http://www.gnome.org/~chpe/programs/uuidgen-c++ (found somewhere on a blog from planet.mozilla.org, don't remember which one)
Comment 4 Bastien Nocera 2006-09-05 15:33:39 UTC
(In reply to comment #3)
> +[scriptable, uuid(aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa)]
> 
> Use 'uuidgen' here (apt-get install libuuid1)

I wanted to use the same as the one provided by the DivX plugin, but I didn't know whether it would make any difference.

> +/* 67DABFBF-D0AB-41fa-9C46-CC0F21721616 */
> +static const nsCID kClassID = 
> +  { 0x67DABFBF, 0xD0AB, 0x41fa,
> +    { 0x9C, 0x46, 0xCC, 0x0F, 0x21, 0x72, 0x16, 0x16 } };
> 
> The others use lowercase hex here... btw you can generate this with the script
> at 
> http://www.gnome.org/~chpe/programs/uuidgen-c++ (found somewhere on a blog from
> planet.mozilla.org, don't remember which one)

OK, will change that.
Comment 5 Christian Persch 2006-09-05 15:54:27 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > +[scriptable, uuid(aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa)]
> > 
> > Use 'uuidgen' here (apt-get install libuuid1)
> 
> I wanted to use the same as the one provided by the DivX plugin, but I didn't
> know whether it would make any difference.

I've no idea if the IID of an object is even accessible to content JS... I think it's fine to use a different IID until proven otherwise :)
Comment 6 Bastien Nocera 2006-09-07 22:11:49 UTC
2006-09-07  Bastien Nocera  <hadess@hadess.net>

        * browser-plugin/Makefile.am:
        * browser-plugin/idl/Makefile.am:
        * browser-plugin/idl/totemIMullYPlayer.idl:
        * browser-plugin/totemGMPPlugin.cpp:
        * browser-plugin/totemMullYPlugin.cpp:
        * browser-plugin/totemMullYPlugin.h:
        * browser-plugin/totemPlugin.cpp:
        * configure.in: Add a new "MullY" plugin, to handle videos on the
        DivX website, masquerading as the "DivX Web Player"
        (Closes: #345554)