After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 345255 - IT_PROG_INTLTOOL incorrectly assumes DATADIRNAME is defined
IT_PROG_INTLTOOL incorrectly assumes DATADIRNAME is defined
Status: RESOLVED FIXED
Product: intltool
Classification: Deprecated
Component: general
0.35.x
Other Linux
: Normal major
: ---
Assigned To: intltool maintainers
intltool maintainers
Depends on:
Blocks:
 
 
Reported: 2006-06-18 18:20 UTC by Loïc Minier
Modified: 2006-10-24 19:35 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
Copy the logic of glib-gettext to define and AC_SUBST(DATADIRNAME) (982 bytes, patch)
2006-10-24 08:06 UTC, Loïc Minier
committed Details | Review

Description Loïc Minier 2006-06-18 18:20:28 UTC
Hi,

Daniel Leidert reported in Debian bug http://bugs.debian.org/373643 that his source tree isn't buildable with intltool 0.35.0 anymore as it now relies on DATADIRNAME being defined when configure runs.  The relevant source tree is accessible with CVS at :pserver:chemical-mime.cvs.sourceforge.net:/cvsroot/chemical-mime.

DATADIRNAME seems to be defined by GLIB_WITH_NLS.

It's also not very clear why intltool's macros use a construct like "$(prefix)/$(DATADIRNAME)/locale".

I suggest you copy the relevant GLIB_WITH_NLS snippet which computes DATADIRNAME to be "share" everywhere and "lib" on Solaris and define a new itlocaledir directory in intltool.m4.  This will break compatibility between intltool.m4 and Makefile.in.in again, but this was already the case between 0.34 and 0.35.0.

Bye,
Comment 1 Daniel Leidert 2006-06-22 01:08:03 UTC
Only AM_GNU_GETTEXT and the GLIB_* macros ship the DATADIRNAME variable. But it is possible to just call AM_PO_SUBDIRS (my project above just translates some XML and desktop files, so I don't need any Glib-dependencies or the large AMG_GNU_GETTEXT macro - this was a suggestion by gettext upstream).
Comment 2 Loïc Minier 2006-10-24 08:06:43 UTC
Created attachment 75287 [details] [review]
Copy the logic of glib-gettext to define and AC_SUBST(DATADIRNAME)

Here's a proposed patch by Jurij Smakov.  It would be nice to comment on the patch soon as we will have to implement one solution or another in the coming days.
Comment 3 Rodney Dawes 2006-10-24 19:35:43 UTC
Committed patch to CVS.