After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 344522 - support non-local destination files
support non-local destination files
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Printing
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2006-06-10 22:56 UTC by Christian Persch
Modified: 2008-10-01 02:13 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
gvfs patch for file backend (5.98 KB, patch)
2008-09-23 15:24 UTC, Marek Kašík 		reviewed Details | Review
actualized patch (7.05 KB, patch)
2008-09-29 14:46 UTC, Marek Kašík 		committed Details | Review

Description Christian Persch 2006-06-10 22:56:23 UTC 
There should be support for saving the file on a non-local filesystem. While this depends on gnome-vfs, gtk+ should at least not inhibit this.
For example, GTK_PRINTER_OPTION_TYPE_FILESAVE handles local filenames instead of URIs. Also the export_filename option of gtkprintoperations probably should be a export_uri?
Comment 1 Marek Kašík 2008-09-23 15:24:49 UTC 
Created attachment 119230 [details] [review]
gvfs patch for file backend

Hi,
this patch adds support for gvfs (successor of gnome-vfs) to GtkPrintbackendFile. It allows users to enter non-local destination for output.
It doesn't change the "export_filename" property of GtkPrintOperation. The "export_filename" is used in run_pdf which calls cairo_pdf_surface_create() but the cairo_pdf_surface_create() doesn't handle URIs.

  Regards

    Marek
Comment 2 Matthias Clasen 2008-09-27 01:32:22 UTC 
Is this missing a 

        g_object_set (priv->combo, "local-only", FALSE, NULL);

in gtkprinteroptionwidget.c ? 
So that one can actually select a non-local destination...
Comment 3 Marek Kašík 2008-09-29 14:46:35 UTC 
Created attachment 119589 [details] [review]
actualized patch

Hi Matthias,
thanks for the comment. I modified patch accordingly.

  Marek
Comment 4 Matthias Clasen 2008-09-29 23:49:52 UTC 
Noticed this comment

   /* TODO: how do we support nonlocal file systems? */

should probably be removed when the patch is committed.
Comment 5 Matthias Clasen 2008-09-29 23:55:44 UTC 
Other than that, it looks good to me.