GNOME Bugzilla – Bug 343972
Need options "Ignore All"/"Replace All" for Spell Check.
Last modified: 2008-01-15 05:01:33 UTC
So far spell check only has Ignore and Replace. Should add features Ignore All and Replace All.
1. open mail composer 2. compose a mail 3. choose Edit->Check Spelling 4, "Spell checker" Dialog will show up giving the suggestions of replacements Only Ignore and replace buttons are available there should be ignore all and replace all, or the users will have to manually click the buttons several times.
Actually currently Ignore means ignore all, do we need to have "ignore once"?
Created attachment 67677 [details] [review] Patch for Gnome-Spell
Created attachment 67678 [details] [review] Patch for gtkhtml
Created attachment 67687 [details] [review] New Patch for Gnome-spell
Created attachment 67688 [details] [review] New Patch for Gtkhtml
Irene, for the gnome-spell patch, please add a shortcut key to the new added button. Also please define a new PROP_SPELL_REPLACE_ALL and use it to make code easy to read. Thanks.
Created attachment 68014 [details] [review] Replace original gnome-spell patch
Created attachment 68015 [details] [review] Replace original gtkhtml patch
to me these patches are definitely evolution 2.9 targets, sadly we cannot get this into 2.8 because of the UI freeze.
We'll wait till evolution 2.9/gnome 2.17 then :).
And now it's too late for that too soon :-/ Please review ASAP
The patch looks OK to me. You might change "repall" to "replaceall" though, so it is better readable. The patches need to be committed after the freeze. Please also send patches to gnome-i18n@gnome.org so that translators get aware of added string.
Rodo, I remember when Irene was working on this patch, she cannot use "replaceall" because it will be conflict with "replace" in bonobo property. The reason is it calling strncmp ("replaceall", "replace", sizeof("replace")) somewhere in its code. I cannot remember clearly, but it is sth. like that. As "repall" in only an internal name, do you think it is ok to use it? Will gnome-spell release a new tarball after the commit?
*** Bug 494467 has been marked as a duplicate of this bug. ***
Created attachment 102876 [details] spell check UI *before* adding the 'Replace All' option
Created attachment 102877 [details] spell check UI *after* adding the 'Replace All' option
Patch in gnome-spell committed to SVN trunk as r427 http://svn.gnome.org/viewvc/gnome-spell?view=revision&revision=427 Patch in gtkhtml committed to SVN trunk as r8686 http://svn.gnome.org/viewvc/gtkhtml?view=revision&revision=8686 UI change has been announced to gnome-doc-list and gnome-i18n (dated 15th) http://mail.gnome.org/archives/gnome-doc-list/2008-January/date.html http://mail.gnome.org/archives/gnome-i18n/2008-January/date.html