After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 343970 - Info Box time is not in local time.
Info Box time is not in local time.
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: Browsing
CVS
Other Linux
: Normal enhancement
: ---
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2006-06-06 02:39 UTC by Bengt Thuree
Modified: 2006-06-07 18:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
small patch (2.12 KB, patch)
2006-06-06 03:07 UTC, Bengt Thuree
none Details | Review

Description Bengt Thuree 2006-06-06 02:39:37 UTC
Rittyan found a bug where the time in browsemode is in local time, but the time in the info box is in UTC time.

From IRC session
<rittyan> I think I found a bug... in our f-spot's browsers photo's date is 6:26 and 6:57... and on sidebar its 2:26 and 2:57...
<rittyan> nothing about this "2:26" and "2:57" in metadata browser :<
<rittyan> (real time of course is 6am)
<rittyan> http://img173.imageshack.us/img173/5682/fspotbug6df.jpg

Checking the InfoBox.cs code on row 271 gives:
	date_label.Text = String.Format ("{0}\n{1}",
					 photo.Time.ToShortDateString (),
					 photo.Time.ToShortTimeString ());

And checking IconView.cs on row 245 gives:
	if (cell_width > 200) {
		date = photo.Time.ToLocalTime ().ToString ();
	} else {
		date = photo.Time.ToLocalTime ().ToShortDateString ();
	}
Comment 1 Bengt Thuree 2006-06-06 03:07:32 UTC
Created attachment 66804 [details] [review]
small patch

A small two liner patch, to display the correct time in the info box.
    date_label.Text = String.Format ("{0}\n{1}",
-                          photo.Time.ToShortDateString (),
-                          photo.Time.ToShortTimeString ());
+                          photo.Time.ToLocalTime ().ToShortDateString (),
+                          photo.Time.ToLocalTime ().ToShortTimeString ());
Comment 2 Larry Ewing 2006-06-07 18:28:56 UTC
committed.