GNOME Bugzilla – Bug 343699
oggmux leaks
Last modified: 2006-06-14 09:14:51 UTC
In gst_ogg_mux_get_headers the caps returned by gst_pad_get_negotiated_caps are not unref'fed. When going to READY the GstOggPad structures managed by GstCollectPads are not properly reset, GstOggPad->pagebuffers is not free'd and GstOggPad->stream is not cleared with ogg_stream_clear. Also, gst_ogg_mux_set_header_on_caps introduces a reference cycle setting the streamheader field, this has been fixed in vorbisenc and theoraenc but not in oggmux.
Created attachment 66667 [details] [review] Fix
Thanks, commited: Patch by: Alessandro Decina <alessandro at nnva dot org> * ext/ogg/gstoggmux.c: (gst_ogg_mux_get_type), (gst_ogg_mux_clear), (gst_ogg_mux_release_pad), (gst_ogg_mux_get_headers), (gst_ogg_mux_set_header_on_caps), (gst_ogg_mux_init_collectpads), (gst_ogg_mux_clear_collectpads), (gst_ogg_mux_change_state): Fix various leaks. Fixes #343699. Add x-smoke mime type.